Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Fix typo in revision.go #10724

Merged
merged 1 commit into from
May 16, 2019
Merged

Doc: Fix typo in revision.go #10724

merged 1 commit into from
May 16, 2019

Conversation

majolo
Copy link
Contributor

@majolo majolo commented May 14, 2019

No description provided.

@majolo majolo changed the title Fix typo in revision.go *: fix typo in revision.go May 14, 2019
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Please modify commit title in this form Expected commit title format '<package>{", "<package>}: <description>' e.g. Doc: Fix typo in revision.go

@majolo majolo changed the title *: fix typo in revision.go Doc: Fix typo in revision.go May 14, 2019
@majolo
Copy link
Contributor Author

majolo commented May 14, 2019

Thanks @spzala - trivial fix, how do I get this merged?

@xiang90
Copy link
Contributor

xiang90 commented May 14, 2019

@majolo the commit message needs to be fixed, not the github pr title.

@spzala
Copy link
Member

spzala commented May 14, 2019

Thanks @spzala - trivial fix, how do I get this merged?

As @xiang90 mentioned, you need to fix the commit title to pass the build other than that it's trivial and looks good. Thanks!

@majolo
Copy link
Contributor Author

majolo commented May 16, 2019

Hey @spzala I've renamed the commit. Build still seems to be failing but can't see how it would relate to this trivial change?

@spzala
Copy link
Member

spzala commented May 16, 2019

@majolo thanks and yes, the build failures not related to the changes.

@spzala
Copy link
Member

spzala commented May 16, 2019

@xiang90 merging this one as it's trivial :-)

@spzala spzala merged commit 71881a4 into etcd-io:master May 16, 2019
@majolo majolo deleted the patch-1 branch May 16, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants