cmd: migrate 'surgery clear-page' command to cobra style command #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mitake @ptabor @serathius @spzala PTAL After this PR gets merged, all surgery commands are migrated to cobra style commands! |
Signed-off-by: Benjamin Wang <wachao@vmware.com>
Signed-off-by: Benjamin Wang <wachao@vmware.com>
Signed-off-by: Benjamin Wang <wachao@vmware.com>
|
ping @ptabor @serathius PTAL |
ahrtr
changed the title
ptabor
reviewed
May 15, 2023
| func newSurgeryClearPageCommand() *cobra.Command { | ||
| var o surgeryClearPageOptions | ||
| clearPageCmd := &cobra.Command{ | ||
| Use: "clear-page <bbolt-file> [options]", |
There was a problem hiding this comment.
Shell we mention --pageId as mandatory option here ?
There was a problem hiding this comment.
Yes, makes sense. We can use cobra.MarkFlagRequired to mark the field required. We should apply the same restriction for other surgery command as well.
Let me do it as a followup. thx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to #472
All surgery commands are migrated to cobra style commands!