Update clap and gtfs structures #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR should not include ebb06e8 and other changes to removing legacy stats fields I guess |
|
oups, I screwd up my git stuff |
antoine-de
force-pushed
the
update_clap_and_gtfs_structures
branch
from
e9cda92
to
f24e60d
Compare
AntoineAugusti
approved these changes
Apr 2, 2024
|
Do you mean cargo audit? It could indeed be nice (but isn't this what is done by dependabot?) |
Yep!
Not sure! Indeed Dependabot may be enough. |
Tristramg
approved these changes
Apr 4, 2024
|
(I can help resolving the conflict if needed.) |
|
oups no, no problem, I just work on this on my spare time, and completly forgot this PR 😁 |
antoine-de
force-pushed
the
update_clap_and_gtfs_structures
branch
from
f24e60d
to
d700eb6
Compare
|
can we merge this? It should not have any impact on transport.data.gouv.fr if I did not miss something 😜 |
AntoineAugusti
approved these changes
Apr 11, 2024
|
LGTM, maybe 🚢 it early next week? |
antoine-de
force-pushed
the
update_clap_and_gtfs_structures
branch
from
d700eb6
to
a3f7022
Compare
antoine-de
force-pushed
the
update_clap_and_gtfs_structures
branch
from
a3f7022
to
f7cbcce
Compare
|
Note: I added the test of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with with
cargo auditis fully happy (we were depending on structopt which is now integrated in clap