feat(Player): implement esx:setGroup event
#1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks pr, can you explain some use cases when you would use this? |
Hi! I've had a few cases where I had to run loops to check for new admins or players who got their permissions set back to user. I usually cache all my results and then modify the table instead of fetching all players constantly. So one use case would be the admin chat, and a scoreboard for example. I have an admin count on the scoreboard, and if we add a new admin or remove one, I can't update my cached table without running a loop every minute or so... I generally think this would be useful as |
|
Hi! @tomiichx Thanks for this pr, i tested, it's works, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.