refactor: use esx cache #1338
refactor: use esx cache #1338
Conversation
|
Hi! It might be a bit misleading to say id, independent since the user would probably think of it as source, it should be called something else because it is an id but it is not the source, it would need wrapping GetPlayerServerId(PlayerId()) this is return player source. So I would suggest that we rename it and then I think it will be appropriate. |
| if playerId ~= PlayerId() then | ||
| playerId = PlayerId() | ||
|
|
||
| ESX.SetPlayerData("id", playerId) |
There was a problem hiding this comment.
I don't think this should be in a loop as the player id never changes - it is static. Same goes for the server id.
There was a problem hiding this comment.
@tomiichx Hi! Ohh yes nice catch it's true thanks.
|
playerid doesnt change but pedid changes... :D Just saying it's probably better to just get PlayerPedId() directly than caching in case of ped mismatch (either changed ped or whatever) |
The PlayerPedId is already cached, but there's no point in caching the PlayerId, it's just more confusing if you enter the cached PlayerPedId and it doesn't work, so we won't merge it. Thanks for your understanding and comments. |
No description provided.