Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add an esx:onCommand event #1264

Closed
wants to merge 1 commit into from
Closed

refactor: add an esx:onCommand event #1264

wants to merge 1 commit into from

Conversation

MoskalykA
Copy link
Contributor

Hi
I suggest adding an esx:onCommand event because the event that retrieves messages from the chat doesn't do that.

@Gellipapa
Copy link
Member

Hi! What and when would you use this event for? Personally I don't see the need for it.

@MoskalykA
Copy link
Contributor Author

Hi! What and when would you use this event for? Personally I don't see the need for it.

Hi, for a logging system, to find out if a staff is abusing these permissions or if a player is pretending not to have done something that does

@Gellipapa
Copy link
Member

Hi! What and when would you use this event for? Personally I don't see the need for it.

Hi, for a logging system, to find out if a staff is abusing these permissions or if a player is pretending not to have done something that does

I see, but here if you don't have the right to do it then the code block won't run and the event won't be triggered, and if it doesn't run and the permission check is done later then the log is false because it says that I typed noclip, but I can't noclip it because it returns false at the end and won't call the noclip method.

@MoskalykA
Copy link
Contributor Author

I see, but here if you don't have the right to do it then the code block won't run and the event won't be triggered, and if it doesn't run and the permission check is done later then the log is false because it says that I typed noclip, but I can't noclip it because it returns false at the end and won't call the noclip method.

I will modify my code

@MoskalykA MoskalykA marked this pull request as draft December 10, 2023 17:40
@Gellipapa Gellipapa self-assigned this Dec 14, 2023
@MoskalykA MoskalykA closed this by deleting the head repository May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Backlog
Development

Successfully merging this pull request may close these issues.

2 participants