Refactoring code for Scaleform movie queries and 3D text drawing #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit involves moving the function for scaleform movie requests directly within the 'scaleform.lua' module, reducing the need to access it through an unnecessary 'Utils' object. Similarly, the 3D text drawing function has been moved to the 'ESX.Game' object, improving the accessibility and simplicity of the code structure.
|
This pr would break backwards compatibility so its not very likely to be merged. Maybe @Gellipapa thinks different abt this but i dont think so. |
|
@Riyane3326 Hi! Thank you for your PR and your work but unfortunately we can't accept this. The scaleform part is not so much risky because people don't call that method by itself, but the DrawText3D out of the Utils table breaks the code 100% and a fresh es_extended afterwards would give the user the error that there is no such method as Utils.DrawText3D so we can't accept that now. It is important to keep backwards compatibility as much as we can and so unfortunately such core methods cannot be refactored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes significant changes to improve the structure of the code. The Scaleform movie query function has been moved directly into the 'scaleform.lua' module, eliminating the need to access it via an unnecessary 'Utils' object. Similarly, the 3D text drawing function has been moved to the 'ESX.Game' object, improving the accessibility and simplicity of the code structure.
These changes are aimed at streamlining access to specific functionality, reducing complexity and making the code clearer and easier to maintain. The adjustments made ensure a better organization of functionalities, facilitating future development and maintenance.