Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ESX.Players): metamethod for counting players #1246

Closed
wants to merge 4 commits into from
Closed

feat(ESX.Players): metamethod for counting players #1246

wants to merge 4 commits into from

Conversation

Thekuca
Copy link
Member

@Thekuca Thekuca commented Oct 15, 2023

Added a metamethod to the ESX.Players table to count players nil proof with #ESX.Players

@Thekuca Thekuca added the awaiting review Awaiting review from PR Manager label Oct 15, 2023
@Gellipapa
Copy link
Member

@Thekuca Hi! Personally, I don't think it's a good idea to introduce this because it might confuse people, it won't be consistent. Users know how ESX.Players works and what helper methods can be used to extract information from it. Later on this can be an unforeseen problem if you override the basic len property.

So I wouldn't do this in Legacy, but such solutions in Infinity which is a completely new system can be integrated there in the future.

@Gellipapa Gellipapa added backlog and removed awaiting review Awaiting review from PR Manager labels Oct 29, 2023
@Thekuca
Copy link
Member Author

Thekuca commented Oct 31, 2023

@Thekuca Hi! Personally, I don't think it's a good idea to introduce this because it might confuse people, it won't be consistent. Users know how ESX.Players works and what helper methods can be used to extract information from it. Later on this can be an unforeseen problem if you override the basic len property.

So I wouldn't do this in Legacy, but such solutions in Infinity which is a completely new system can be integrated there in the future.

I agree with you.

@Thekuca Thekuca closed this by deleting the head repository Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🔖 Backlog
Development

Successfully merging this pull request may close these issues.

2 participants