Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callback await #1107

Closed
wants to merge 4 commits into from
Closed

Callback await #1107

wants to merge 4 commits into from

Conversation

CsokiHUN
Copy link
Member

@CsokiHUN CsokiHUN commented Jul 9, 2023 •
edited
Loading

  • ESX.TriggerServerCallback.Await
  • ESX.TriggerClientCallback.Await

@CsokiHUN CsokiHUN added the enhancement New feature or request label Jul 9, 2023
@TheFantomas TheFantomas marked this pull request as draft July 10, 2023 14:35
@Gellipapa Gellipapa changed the base branch from main to dev July 10, 2023 15:12
@Gellipapa
Copy link
Member

@CsokiHUN Hi! What is the status here? Need to test?

@CsokiHUN
Copy link
Member Author

@CsokiHUN Hi! What is the status here? Need to test?

Please test, but only the server side callback is ready

@TheFantomas
Copy link
Member

@CsokiHUN Hi! What is the status here? Need to test?

Please test, but only the server side callback is ready

I test this @CsokiHUN. Its working good. You can add ESX.TriggerClientCallback.Await.

@mahanmoulaei
Copy link

I test this @CsokiHUN. Its working good. You can add ESX.TriggerClientCallback.Await.

I'm not really sure what did you test and how did you find out it's woking good, because Lua metamethods cannot be msgpacked in FiveM.

@Gellipapa
Copy link
Member

@TheFantomas @CsokiHUN What a current status? Were you able to test it?

@CsokiHUN
Copy link
Member Author

I'm not really sure what did you test and how did you find out it's woking good, because Lua metamethods cannot be msgpacked in FiveM.

you are absolutely right, I close PR

@CsokiHUN CsokiHUN closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@CsokiHUN CsokiHUN

@TheFantomas TheFantomas

Labels
enhancement New feature or request
Projects
ESX Legacy Roadmap
Status: 🔖 Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CsokiHUN @Gellipapa @TheFantomas @mahanmoulaei