Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: for keychain lock issue while during notorization arm64 dmg #950

Merged
merged 1 commit into from
May 16, 2024

Conversation

kolipakakondal
Copy link
Collaborator

@kolipakakondal kolipakakondal commented May 16, 2024

Description

Please include a summary of the change and which issue is fixed.

Fixes # (IEP-XXX)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • Component 1
  • Component 2

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

  • Chores
    • Renamed and restructured the notarization process for macOS DMG files.
    • Added separate notarization steps for x86_64 and aarch64 architectures.
    • Updated keychain profile for aarch64 notarization.

Copy link

coderabbitai bot commented May 16, 2024

Walkthrough

The .github/workflows/ci_beta.yml file has been updated to enhance the notarization process for macOS DMG files of Espressif-IDE. The changes include renaming and restructuring the notarization steps to handle x86_64 and aarch64 architectures separately, ensuring a more organized and efficient workflow.

Changes

File Change Summary
.github/workflows/ci_beta.yml Renamed job to Notarization of Espressif-IDE-macosx-cocoa-x86_64.dmg and added a new job for Notarization of Espressif-IDE-macosx-cocoa-aarch64.dmg. Updated keychain profile name for aarch64 notarization.

🐇
In the land of code and bytes,
A rabbit hops through starry nights.
With workflows clear and steps anew,
For x86 and aarch64 too.
Espressif-IDE, now notarized,
In macOS realms, it stands revised.
Hoppity hop, the changes sing,
Efficiency in every spring!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kolipakakondal kolipakakondal merged commit a860489 into master May 16, 2024
3 of 4 checks passed
@kolipakakondal kolipakakondal deleted the keychainissue branch May 16, 2024 08:32
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 482a19a and 718f88d.
Files selected for processing (1)
  • .github/workflows/ci_beta.yml (1 hunks)
Additional comments not posted (2)
.github/workflows/ci_beta.yml (2)

66-77: The notarization job for the x86_64 architecture looks good.


78-86: The notarization job for the aarch64 architecture looks good. Ensure the keychain profile name "ide-notarytool-profile-arm64" is unique to avoid conflicts.

Verification successful

The notarization job for the aarch64 architecture looks good. The keychain profile name "ide-notarytool-profile-arm64" is unique and does not conflict with any existing profiles.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the uniqueness of the keychain profile name.

# Test: Search for the keychain profile name. Expect: Only occurances of the new profile name.
rg --type yaml $'ide-notarytool-profile-arm64'

Length of output: 45



Script:

#!/bin/bash
# Description: Verify the uniqueness of the keychain profile name across all file types.

# Test: Search for the keychain profile name. Expect: Only occurrences of the new profile name.
rg 'ide-notarytool-profile-arm64'

Length of output: 33

@coderabbitai coderabbitai bot mentioned this pull request Sep 23, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant