-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: added batik plugins for TM4E plugin to dependencies #944
Conversation
WalkthroughThe recent changes involve the removal of various Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- releng/com.espressif.idf.target/com.espressif.idf.target.target (1 hunks)
- releng/com.espressif.idf.update/category.xml (1 hunks)
Files skipped from review due to trivial changes (2)
- releng/com.espressif.idf.target/com.espressif.idf.target.target
- releng/com.espressif.idf.update/category.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- releng/com.espressif.idf.update/category.xml (1 hunks)
Additional comments not posted (4)
releng/com.espressif.idf.update/category.xml (4)
93-95
: Addition oforg.apache.batik.i18n
bundle is correctly placed under the appropriate category.
96-98
: Addition oforg.apache.batik.css
bundle is correctly placed under the appropriate category.
99-101
: Addition oforg.apache.batik.constants
bundle is correctly placed under the appropriate category.
102-104
: Addition oforg.apache.batik.util
bundle is correctly placed under the appropriate category.
@AndriiFilippov Please run through update site and see if you have any installation issues? |
@sigmaaa hi ! Tested under: Espressif IDE 2.12.1 -> update to 3.0.0.zip -> ✔️ LGTM 👍 |
Description
We don't need these batik plugins if we are using latest Espressif-IDE or using latest eclipse-cdt and update site because latest batik dependencies pick up automatically for that case, but if we update older version of Espressif-IDE with latest update site these batik dependencies could be missing. As solution, in this pr I added required batik dependecies for TM4E to depencies in category.xml
Fixes # (IEP-XXX)
Type of change
Please delete options that are not relevant.
How has this been tested?
update the older version of Espressif-IDE and install dependencies from the list in the update site -> verify that syntax highlight works along with other functionalities
Test Configuration:
Dependent components impacted by this PR:
Checklist
Summary by CodeRabbit