-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bundled JRE 17 with Espressif-IDE #942
Conversation
WalkthroughThe recent updates focus on enhancing Java support across various modules and platforms within the project. Key changes include upgrading Java SE versions from 11 to 17 for Linux, macOS, and Windows, and integrating the Eclipse JustJ OpenJDK Hotspot JRE Full feature. These adjustments ensure compatibility and performance improvements across different operating systems and development environments. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- bundles/pom.xml (1 hunks)
- releng/com.espressif.idf.configuration/pom.xml (1 hunks)
- releng/com.espressif.idf.product/idf.product (2 hunks)
- releng/com.espressif.idf.product/pom.xml (2 hunks)
- releng/com.espressif.idf.target/com.espressif.idf.target.target (1 hunks)
Files skipped from review due to trivial changes (3)
- releng/com.espressif.idf.configuration/pom.xml
- releng/com.espressif.idf.product/idf.product
- releng/com.espressif.idf.target/com.espressif.idf.target.target
Additional comments not posted (2)
bundles/pom.xml (1)
43-72
: Ensure the new plugin configuration aligns with project requirements for Java 17.The addition of the
<plugin>
configuration fororg.eclipse.tycho:target-platform-configuration
with the execution environment set toorg.eclipse.justj.openjdk.hotspot.jre.full-17
is crucial for ensuring that the IDE is compatible with Java 17 across different operating systems. This change aligns with the PR's objective to enhance IDE functionality and compatibility with newer Java features.releng/com.espressif.idf.product/pom.xml (1)
Line range hint
117-144
: Ensure the new execution environment configuration aligns with project requirements for Java 17.The addition of the
<executionEnvironment>
tag specifyingorg.eclipse.justj.openjdk.hotspot.jre.full-17
in thetarget-platform-configuration
plugin ensures that the Espressif IDE will utilize Java 17, enhancing its performance and compatibility across different platforms. This change is consistent with the updates in other configuration files and supports the PR's goals.
@sigmaaa hi ! Tested under: Able to run Eclipse -> use Espressif Plugin -> create / build / flash / monitor project -> without Java installed. ✔️ LGTM 👍 |
Description
Bundled JRE 17 with Espressif-IDE
Type of change
Please delete options that are not relevant.
How has this been tested?
"-vm
plugins/org.eclipse.justj.openjdk.hotspot.jre.full.win32.x86_64_17.0.11.v20240426-1830/jre/bin"
Test Configuration:
Dependent components impacted by this PR:
Checklist
Summary by CodeRabbit
New Features
Refactor