Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update min jre requirement to JavaSE-17 to all the plugins #934

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

kolipakakondal
Copy link
Collaborator

@kolipakakondal kolipakakondal commented Apr 8, 2024

Description

Update all the plugins min JRE requirement to JavaSE-17

Fixes # (IEP-1200)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How has this been tested?

  • Espressif-IDE should work with JavaSE 17 and higher without any issues

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • NA

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

  • Refactor
    • Updated the JavaSE version from 11 to 17 across various components to enhance performance and compatibility with newer Java standards.
  • Chores
    • Adjusted compiler settings and execution environments to align with JavaSE-17, ensuring improved stability and future-proofing of the development environment.

@kolipakakondal kolipakakondal changed the title fix: Update min jre requirement to javase-17 to all the plugins fix: Update min jre requirement to JavaSE-17 to all the plugins Apr 8, 2024
Copy link

coderabbitai bot commented Apr 8, 2024

Walkthrough

The overarching change across the project involves a significant upgrade from JavaSE version 11 to 17. This comprehensive update affects the classpath configurations, Java compiler settings, and required execution environments within various bundles and components of the project. The adjustment aligns the project with the latest Java standards, enhancing its performance, security, and compatibility with modern Java features.

Changes

File Path Change Summary
.../.classpath Updated JavaSE version from 11 to 17.
.../.settings/org.eclipse.jdt.core.prefs Updated Java compiler settings to target platform 17 and compliance level 17. Adjustments in error/warning handling for various language features in specific bundles.
.../META-INF/MANIFEST.MF Updated required execution environment from JavaSE-11 to JavaSE-17.

🐇✨
A leap from eleven to seventeen, so keen,
Through the fields of Java, fresh and green.
Bundles and prefs, all neatly aligned,
With the future of code, we're now entwined.
Hop, hop, hooray, for the changes we've seen!
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between bc0d6da and 6d398f2.
Files selected for processing (47)
  • bundles/com.espressif.idf.branding/.classpath (1 hunks)
  • bundles/com.espressif.idf.branding/.settings/org.eclipse.jdt.core.prefs (1 hunks)
  • bundles/com.espressif.idf.branding/META-INF/MANIFEST.MF (1 hunks)
  • bundles/com.espressif.idf.core/.classpath (1 hunks)
  • bundles/com.espressif.idf.core/.settings/org.eclipse.jdt.core.prefs (2 hunks)
  • bundles/com.espressif.idf.core/META-INF/MANIFEST.MF (1 hunks)
  • bundles/com.espressif.idf.debug.gdbjtag.openocd/.classpath (1 hunks)
  • bundles/com.espressif.idf.debug.gdbjtag.openocd/.settings/org.eclipse.jdt.core.prefs (1 hunks)
  • bundles/com.espressif.idf.debug.gdbjtag.openocd/META-INF/MANIFEST.MF (1 hunks)
  • bundles/com.espressif.idf.help/.classpath (1 hunks)
  • bundles/com.espressif.idf.help/.settings/org.eclipse.jdt.core.prefs (1 hunks)
  • bundles/com.espressif.idf.help/META-INF/MANIFEST.MF (1 hunks)
  • bundles/com.espressif.idf.launch.serial.core/.classpath (1 hunks)
  • bundles/com.espressif.idf.launch.serial.core/.settings/org.eclipse.jdt.core.prefs (2 hunks)
  • bundles/com.espressif.idf.launch.serial.core/META-INF/MANIFEST.MF (1 hunks)
  • bundles/com.espressif.idf.launch.serial.ui/.classpath (1 hunks)
  • bundles/com.espressif.idf.launch.serial.ui/.settings/org.eclipse.jdt.core.prefs (2 hunks)
  • bundles/com.espressif.idf.launch.serial.ui/META-INF/MANIFEST.MF (1 hunks)
  • bundles/com.espressif.idf.sdk.config.core/.classpath (1 hunks)
  • bundles/com.espressif.idf.sdk.config.core/.settings/org.eclipse.jdt.core.prefs (1 hunks)
  • bundles/com.espressif.idf.sdk.config.core/META-INF/MANIFEST.MF (1 hunks)
  • bundles/com.espressif.idf.sdk.config.ui/.classpath (1 hunks)
  • bundles/com.espressif.idf.sdk.config.ui/.settings/org.eclipse.jdt.core.prefs (1 hunks)
  • bundles/com.espressif.idf.sdk.config.ui/META-INF/MANIFEST.MF (1 hunks)
  • bundles/com.espressif.idf.serial.monitor/.classpath (1 hunks)
  • bundles/com.espressif.idf.serial.monitor/.settings/org.eclipse.jdt.core.prefs (1 hunks)
  • bundles/com.espressif.idf.serial.monitor/META-INF/MANIFEST.MF (1 hunks)
  • bundles/com.espressif.idf.terminal.connector.serial/.classpath (1 hunks)
  • bundles/com.espressif.idf.terminal.connector.serial/.settings/org.eclipse.jdt.core.prefs (2 hunks)
  • bundles/com.espressif.idf.terminal.connector.serial/META-INF/MANIFEST.MF (1 hunks)
  • bundles/com.espressif.idf.terminal.connector/.classpath (1 hunks)
  • bundles/com.espressif.idf.terminal.connector/.settings/org.eclipse.jdt.core.prefs (2 hunks)
  • bundles/com.espressif.idf.terminal.connector/META-INF/MANIFEST.MF (1 hunks)
  • bundles/com.espressif.idf.ui/.classpath (1 hunks)
  • bundles/com.espressif.idf.ui/.settings/org.eclipse.jdt.core.prefs (2 hunks)
  • bundles/com.espressif.idf.ui/META-INF/MANIFEST.MF (1 hunks)
  • bundles/com.espressif.idf.wokwi/.classpath (1 hunks)
  • bundles/com.espressif.idf.wokwi/.settings/org.eclipse.jdt.core.prefs (1 hunks)
  • bundles/com.espressif.idf.wokwi/META-INF/MANIFEST.MF (1 hunks)
  • common/com.espressif.idf.nl.translator/.classpath (1 hunks)
  • common/com.espressif.idf.nl.translator/.settings/org.eclipse.jdt.core.prefs (1 hunks)
  • common/com.espressif.idf.nl.translator/META-INF/MANIFEST.MF (1 hunks)
  • releng/com.espressif.idf.target/.classpath (1 hunks)
  • releng/com.espressif.idf.target/.settings/org.eclipse.jdt.core.prefs (1 hunks)
  • tests/com.espressif.idf.core.test/.classpath (1 hunks)
  • tests/com.espressif.idf.core.test/.settings/org.eclipse.jdt.core.prefs (1 hunks)
  • tests/com.espressif.idf.core.test/META-INF/MANIFEST.MF (1 hunks)
Files not reviewed due to errors (7)
  • (no review received)
  • (no review received)
  • (no review received)
  • (no review received)
  • (no review received)
  • (no review received)
  • (no review received)
Files skipped from review due to trivial changes (9)
  • bundles/com.espressif.idf.help/META-INF/MANIFEST.MF
  • bundles/com.espressif.idf.launch.serial.core/.classpath
  • bundles/com.espressif.idf.serial.monitor/.settings/org.eclipse.jdt.core.prefs
  • bundles/com.espressif.idf.terminal.connector.serial/.settings/org.eclipse.jdt.core.prefs
  • bundles/com.espressif.idf.terminal.connector/META-INF/MANIFEST.MF
  • bundles/com.espressif.idf.ui/.classpath
  • bundles/com.espressif.idf.wokwi/.settings/org.eclipse.jdt.core.prefs
  • bundles/com.espressif.idf.wokwi/META-INF/MANIFEST.MF
  • common/com.espressif.idf.nl.translator/META-INF/MANIFEST.MF
Additional comments not posted (39)
bundles/com.espressif.idf.branding/META-INF/MANIFEST.MF (1)

8-8: Update to JavaSE-17 in the manifest file is correctly implemented.

bundles/com.espressif.idf.branding/.settings/org.eclipse.jdt.core.prefs (2)

3-4: Ensure the project's documentation reflects the updated Java version requirement.


10-10: Confirm that all dependencies are compatible with Java 17 to avoid runtime issues.

common/com.espressif.idf.nl.translator/.settings/org.eclipse.jdt.core.prefs (2)

2-4: Verify that inline JSR bytecode generation is necessary and compatible with Java 17.


10-10: Check for any deprecated APIs or features used in the code that may be affected by the Java 17 update.

bundles/com.espressif.idf.debug.gdbjtag.openocd/.settings/org.eclipse.jdt.core.prefs (1)

1-10: Ensure that the OpenOCD debugging tools are fully compatible with Java 17.

bundles/com.espressif.idf.launch.serial.ui/.classpath (1)

3-3: Confirm that all serial communication libraries are compatible with JavaSE-17.

releng/com.espressif.idf.target/.classpath (1)

3-3: Ensure Maven dependencies are updated and compatible with JavaSE-17.

bundles/com.espressif.idf.help/.settings/org.eclipse.jdt.core.prefs (2)

3-4: Review the help content for any Java version-specific references that need updating.


11-11: Check for any deprecated features in the help system that may be affected by the Java 17 update.

bundles/com.espressif.idf.sdk.config.core/.settings/org.eclipse.jdt.core.prefs (2)

3-4: Ensure SDK configuration tools are fully compatible with Java 17.


11-11: Check for any SDK-specific features or APIs that may be deprecated in Java 17.

releng/com.espressif.idf.target/.settings/org.eclipse.jdt.core.prefs (2)

3-4: Update to Java 17 compliance and target platform aligns with project objectives.


11-11: Correctly updated the source compatibility to Java 17.

tests/com.espressif.idf.core.test/.settings/org.eclipse.jdt.core.prefs (2)

2-4: Ensuring inline JSR bytecode generation is enabled and targeting Java 17 is consistent with project upgrade requirements.


11-11: Source compatibility updated to Java 17, ensuring consistency across the project.

bundles/com.espressif.idf.sdk.config.ui/META-INF/MANIFEST.MF (1)

15-15: Updating the required execution environment to JavaSE-17 in the manifest file aligns with the project's upgrade to Java 17.

bundles/com.espressif.idf.terminal.connector.serial/.classpath (1)

3-3: Correctly updated the JRE container to JavaSE-17, ensuring compatibility with the new Java version requirement.

bundles/com.espressif.idf.sdk.config.core/META-INF/MANIFEST.MF (1)

14-14: The update to JavaSE-17 as the required execution environment in the manifest file is appropriate for the project's transition to Java 17.

bundles/com.espressif.idf.ui/.settings/org.eclipse.jdt.core.prefs (2)

4-6: Updating the compiler's target platform and compliance level to Java 17 ensures consistency with the project's new Java version requirement.


15-15: Source compatibility set to Java 17, aligning with the project's upgrade strategy.

bundles/com.espressif.idf.help/.classpath (1)

3-3: The JRE container update to JavaSE-17 in the classpath configuration is correctly implemented, ensuring compatibility with Java 17.

bundles/com.espressif.idf.launch.serial.core/META-INF/MANIFEST.MF (1)

7-7: The manifest file's update to require JavaSE-17 ensures the project's compatibility with the latest Java standards.

bundles/com.espressif.idf.launch.serial.ui/META-INF/MANIFEST.MF (1)

6-6: Update to JavaSE-17 aligns with project objectives. Ensure all dependencies are compatible with JavaSE-17.

bundles/com.espressif.idf.serial.monitor/META-INF/MANIFEST.MF (1)

15-15: Update to JavaSE-17 aligns with project objectives. Ensure all dependencies are compatible with JavaSE-17.

tests/com.espressif.idf.core.test/.classpath (1)

9-9: Update to JavaSE-17 aligns with project objectives. Ensure all test libraries and tools are compatible with JavaSE-17.

bundles/com.espressif.idf.terminal.connector.serial/META-INF/MANIFEST.MF (1)

22-22: Update to JavaSE-17 aligns with project objectives. Ensure all dependencies are compatible with JavaSE-17.

bundles/com.espressif.idf.core/.classpath (1)

22-22: Update to JavaSE-17 aligns with project objectives. Ensure all libraries and tools used are compatible with JavaSE-17.

bundles/com.espressif.idf.debug.gdbjtag.openocd/META-INF/MANIFEST.MF (1)

37-37: Update to JavaSE-17 aligns with project objectives. Ensure all dependencies are compatible with JavaSE-17.

bundles/com.espressif.idf.ui/META-INF/MANIFEST.MF (1)

52-52: Update to JavaSE-17 aligns with project objectives. Ensure all dependencies are compatible with JavaSE-17.

bundles/com.espressif.idf.core/META-INF/MANIFEST.MF (1)

30-30: Update to JavaSE-17 aligns with project objectives. Ensure all dependencies are compatible with JavaSE-17.

bundles/com.espressif.idf.serial.monitor/.classpath (1)

20-20: Update to JavaSE-17 is correctly applied.

tests/com.espressif.idf.core.test/META-INF/MANIFEST.MF (1)

8-8: Update to JavaSE-17 in the manifest file is correctly applied.

bundles/com.espressif.idf.core/.settings/org.eclipse.jdt.core.prefs (1)

13-14: Java compiler settings update to target platform and compliance level 17 is correctly applied.

bundles/com.espressif.idf.launch.serial.core/.settings/org.eclipse.jdt.core.prefs (1)

23-25: Java compiler settings update to target platform and compliance level 17 is correctly applied.

bundles/com.espressif.idf.terminal.connector/.settings/org.eclipse.jdt.core.prefs (1)

33-35: Java compiler settings update to target platform and compliance level 17 is correctly applied.

bundles/com.espressif.idf.launch.serial.ui/.settings/org.eclipse.jdt.core.prefs (3)

33-33: Update to target platform for code generation aligns with JavaSE-17 requirements.


35-35: Update to compiler compliance level ensures adherence to JavaSE-17 language specifications.


150-150: Update to source compatibility ensures code is written for JavaSE-17.

Copy link
Collaborator

@sigmaaa sigmaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolipakakondal kolipakakondal merged commit 05101c8 into master Apr 11, 2024
2 of 6 checks passed
@kolipakakondal kolipakakondal deleted the IEP-1200 branch April 11, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants