-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set default query-driver path based on current active target #927
Conversation
WalkthroughThis update introduces a notable simplification in method naming within the IDF Eclipse plugin and enhances the plugin's capability to resolve cross-compiler toolchain headers. The renaming of a method for obtaining the toolchain executable path reflects a broader applicability, while a new method addition aims to improve the development environment's understanding of toolchain specifics. Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (2)
- bundles/com.espressif.idf.core/src/com/espressif/idf/core/util/IDFUtil.java (1 hunks)
- bundles/com.espressif.idf.lsp/src/com/espressif/idf/lsp/preferences/IDFClangdOptionsDefaults.java (1 hunks)
Description
Set default query-driver path based on current active target
Fixes # (IEP-1195)
Type of change
How has this been tested?
However, there are challenges when you switch between targets, user has to manually set query-driver path in the prefernces and that will restart the lsp.
Test Configuration:
Dependent components impacted by this PR:
Checklist
Summary by CodeRabbit