Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set default query-driver path based on current active target #927

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

kolipakakondal
Copy link
Collaborator

@kolipakakondal kolipakakondal commented Apr 6, 2024

Description

Set default query-driver path based on current active target

Fixes # (IEP-1195)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

  • Create a new project with a selected target
  • Build a project
  • Open the editor and observe that all the headers are resolved
  • Verify the preferences, query-driver is set for the active target

However, there are challenges when you switch between targets, user has to manually set query-driver path in the prefernces and that will restart the lsp.

Test Configuration:

  • ESP-IDF Version: master
  • OS (Windows,Linux and macOS):macOS

Dependent components impacted by this PR:

  • New project
  • Indexer

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

  • Refactor
    • Updated method naming for better clarity in toolchain path retrieval.
  • New Features
    • Enhanced language server capabilities with automatic toolchain path resolution for cross-compiler headers.

Copy link

coderabbitai bot commented Apr 6, 2024

Walkthrough

This update introduces a notable simplification in method naming within the IDF Eclipse plugin and enhances the plugin's capability to resolve cross-compiler toolchain headers. The renaming of a method for obtaining the toolchain executable path reflects a broader applicability, while a new method addition aims to improve the development environment's understanding of toolchain specifics.

Changes

File Path Change Summary
.../idf.core/src/.../IDFUtil.java Renamed getXtensaToolchainExePathForActiveTarget to getToolchainExePathForActiveTarget.
.../idf.lsp/src/.../IDFClangdOptionsDefaults.java Added queryDriver() method for toolchain path resolution.

Possibly related issues

🐰✨
In the realm of code, where Eclipse does reign,
A rabbit hopped in, with improvements to gain.
"Rename and add," it said with a cheer,
"For better paths ahead, let's make it clear."
With a whisk of its tail, errors fade away,
Celebrating the changes, in the light of day. 🚀🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between cd49fcf and 8cfa2e3.
Files selected for processing (2)
  • bundles/com.espressif.idf.core/src/com/espressif/idf/core/util/IDFUtil.java (1 hunks)
  • bundles/com.espressif.idf.lsp/src/com/espressif/idf/lsp/preferences/IDFClangdOptionsDefaults.java (1 hunks)

@kolipakakondal kolipakakondal merged commit 47b1dc7 into master Apr 8, 2024
2 of 6 checks passed
@kolipakakondal kolipakakondal deleted the IEP-1195 branch April 8, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant