IEP-1179: Change to windows self hosted runner #911
Conversation
WalkthroughThe recent updates across various configuration and test files primarily focus on upgrading versions for Maven, Python, and Tycho, enhancing CI workflows, and refining test utilities and methods. These changes aim to improve the build process, testing efficiency, and overall code maintainability in a systematic and modernized development environment. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- .github/workflows/ci.yml (1 hunks)
- .github/workflows/ci_windows.yml (1 hunks)
Additional comments: 2
.github/workflows/ci_windows.yml (1)
- 15-18: The modification to the
runs-onconfiguration to includeself-hosted,eclipse,BrnoWIN0007is a strategic move towards utilizing specific, self-hosted runners for Windows builds. This should offer better control over the build environment and potentially improve build performance. Ensure that these runners are properly configured and available for use to avoid disruptions in the CI process..github/workflows/ci.yml (1)
- 18-18: The addition of
BrnoUBU0004to theruns-onconfiguration is a positive step towards expanding the selection of runners, likely for Ubuntu-based tasks. Ensure that this runner is properly configured and available for use to avoid disruptions in the CI process.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/ci_windows.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/ci_windows.yml
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/ci_windows.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/ci_windows.yml
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
releng/com.espressif.idf.configuration/pom.xmlis excluded by:!**/*.xml
Files selected for processing (2)
- .github/workflows/ci.yml (2 hunks)
- .github/workflows/ci_windows.yml (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- .github/workflows/ci.yml
- .github/workflows/ci_windows.yml
| @@ -178,7 +178,7 @@ private static void whenProjectIsBuiltUsingToolbarButton() throws IOException | |||
| { | |||
| bot.toolbarButtonWithTooltip("Build").click(); | |||
| ProjectTestOperations.waitForProjectBuild(bot); | |||
| TestWidgetWaitUtility.waitForOperationsInProgressToFinish(bot); | |||
| // TestWidgetWaitUtility.waitForOperationsInProgressToFinish(bot); | |||
There was a problem hiding this comment.
Commenting out waitForOperationsInProgressToFinish may lead to flaky tests due to incomplete operations. Consider reverting this change or justifying its removal.
| @@ -188,7 +188,7 @@ | |||
|
|
|||
| private static void thenConsoleShowsBuildSuccessful() | |||
| { | |||
| TestWidgetWaitUtility.waitForOperationsInProgressToFinish(bot); | |||
| // TestWidgetWaitUtility.waitForOperationsInProgressToFinish(bot); | |||
There was a problem hiding this comment.
Commenting out waitForOperationsInProgressToFinish may lead to flaky tests due to incomplete operations. Consider reverting this change or justifying its removal.
| @@ -208,7 +208,7 @@ | |||
|
|
|||
| private static void cleanTestEnv() | |||
| { | |||
| TestWidgetWaitUtility.waitForOperationsInProgressToFinish(bot); | |||
| // TestWidgetWaitUtility.waitForOperationsInProgressToFinish(bot); | |||
There was a problem hiding this comment.
Commenting out waitForOperationsInProgressToFinish may lead to flaky tests due to incomplete operations. Consider reverting this change or justifying its removal.
| @@ -284,7 +284,7 @@ private static void whenProjectIsCopied(String projectName, String projectCopyNa | |||
| { | |||
| ProjectTestOperations.copyProjectToExistingWorkspace(projectName, projectCopyName, bot, | |||
| DefaultPropertyFetcher.getLongPropertyValue("default.project.copy.wait", 60000)); | |||
| TestWidgetWaitUtility.waitForOperationsInProgressToFinish(bot); | |||
| // TestWidgetWaitUtility.waitForOperationsInProgressToFinish(bot); | |||
There was a problem hiding this comment.
Commenting out waitForOperationsInProgressToFinish may lead to flaky tests due to incomplete operations. Consider reverting this change or justifying its removal.
| @@ -305,7 +305,7 @@ | |||
| { | |||
| ProjectTestOperations.buildProjectUsingContextMenu(projectName, bot); | |||
| ProjectTestOperations.waitForProjectBuild(bot); | |||
| TestWidgetWaitUtility.waitForOperationsInProgressToFinish(bot); | |||
| // TestWidgetWaitUtility.waitForOperationsInProgressToFinish(bot); | |||
There was a problem hiding this comment.
Commenting out waitForOperationsInProgressToFinish may lead to flaky tests due to incomplete operations. Consider reverting this change or justifying its removal.
| @@ -404,25 +404,25 @@ | |||
|
|
|||
| private static void closeProject(String projectName) | |||
| { | |||
| TestWidgetWaitUtility.waitForOperationsInProgressToFinish(bot); | |||
| // TestWidgetWaitUtility.waitForOperationsInProgressToFinish(bot); | |||
There was a problem hiding this comment.
Commenting out waitForOperationsInProgressToFinish may lead to flaky tests due to incomplete operations. Consider reverting this change or justifying its removal.
| ProjectTestOperations.closeProject(projectName, bot); | ||
| } | ||
|
|
||
| private static void deleteProject(String projectName) | ||
| { | ||
| TestWidgetWaitUtility.waitForOperationsInProgressToFinish(bot); | ||
| // TestWidgetWaitUtility.waitForOperationsInProgressToFinish(bot); |
There was a problem hiding this comment.
Commenting out waitForOperationsInProgressToFinish may lead to flaky tests due to incomplete operations. Consider reverting this change or justifying its removal.
| ProjectTestOperations.deleteProject(projectName, bot); | ||
| } | ||
|
|
||
| private static void deleteProjectAndConfigs(String projectName) | ||
| { | ||
| TestWidgetWaitUtility.waitForOperationsInProgressToFinish(bot); | ||
| // TestWidgetWaitUtility.waitForOperationsInProgressToFinish(bot); |
There was a problem hiding this comment.
Commenting out waitForOperationsInProgressToFinish may lead to flaky tests due to incomplete operations. Consider reverting this change or justifying its removal.
| ProjectTestOperations.deleteProjectAndAllRelatedConfigs(projectName, bot); | ||
| } | ||
|
|
||
| private static void cleanTestEnv() | ||
| { | ||
| TestWidgetWaitUtility.waitForOperationsInProgressToFinish(bot); | ||
| // TestWidgetWaitUtility.waitForOperationsInProgressToFinish(bot); |
There was a problem hiding this comment.
Commenting out waitForOperationsInProgressToFinish may lead to flaky tests due to incomplete operations. Consider reverting this change or justifying its removal.
… triggered in eclipse
Change to ci for windows self hosted runner
Summary by CodeRabbit
--openfolderoption from theblesscommand in the DMG creation script, altering how the mounted window appears.