-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updating espressif openocd path during startup #910
Conversation
WalkthroughThe update introduces an enhancement to the Eclipse plugin for the Espressif IDF, focusing on improving the user experience by ensuring the OpenOCD path is correctly set up. By importing Changes
Related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- bundles/com.espressif.idf.ui/src/com/espressif/idf/ui/InitializeToolsStartup.java (2 hunks)
Additional comments: 2
bundles/com.espressif.idf.ui/src/com/espressif/idf/ui/InitializeToolsStartup.java (2)
- 44-44: The addition of the import statement for
IDFUtil
is appropriate for enabling the use ofIDFUtil.updateEspressifPrefPageOpenocdPath()
method later in the code. This change is necessary for the intended functionality.- 193-193: The invocation of
IDFUtil.updateEspressifPrefPageOpenocdPath()
is central to the PR's objective of updating the OpenOCD path during startup. It's correctly placed in the code flow. However, it's important to verify that this method does not introduce any side effects or dependencies that could negatively impact the startup process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self reviewed. Tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@AndriiFilippov Please verify |
@sigmaaa hi ! Tested under: Able to debug esp32 target. LGTM 👍 |
Description
fixed an issue when during the first start of Espressif-IDE, the openocd path is undefined.
Fixes # (IEP-1176)
Type of change
Please delete options that are not relevant.
How has this been tested?
Test Configuration:
Dependent components impacted by this PR:
Checklist
Summary by CodeRabbit