Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IEP-1135 Incorrect default gdb executable for RISCV targets #874

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

sigmaaa
Copy link
Collaborator

@sigmaaa sigmaaa commented Dec 18, 2023

Description

Fixed debugger patterns to get correct gdb executables. The problem was, that without "$" at the end we could get the wrong executable, for example, bin\xtensa-esp32-elf-gdb-3.7.exe, etc.

Fixes # (IEP-1135)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Test 1:
try to debug with different targets
Test 2:
check the actual executable path in the debugger tab for different targets
Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • Debugger tab

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Copy link
Collaborator Author

@sigmaaa sigmaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self reviewed

@kolipakakondal
Copy link
Collaborator

Hi @AndriiFilippov Can you please verify this

@kolipakakondal kolipakakondal added this to the v2.12.0 milestone Dec 19, 2023
@AndriiFilippov
Copy link
Collaborator

AndriiFilippov commented Dec 19, 2023

@sigmaaa , @kolipakakondal hi !

Tested under:
OS: Windows 10 / MacOS
ESP-IDF: v5.1.2

LGTM 👍 Able to Debug.

  1. on Windows: Debug works but for targets H2 / C6 the USB-JTAG ports are not identified in Launch Target :
    image

  2. all platforms: H2 target Debug starts very slow and with some errors like this:
    image
    image

  3. in general, the Debug console is accompanied with errors like this, but without impact on Debug work.

image

Should I create separate tasks for those issues ?

@sigmaaa
Copy link
Collaborator Author

sigmaaa commented Dec 19, 2023

Hi @AndriiFilippov, yes we can create a separate issue for this since it's not related to the PR. Thanks

@kolipakakondal kolipakakondal merged commit c5c714e into master Dec 22, 2023
3 of 6 checks passed
@kolipakakondal kolipakakondal deleted the IEP-1135 branch December 22, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants