-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Eclipse 4.30(Eclipse 2023-12) #869
Conversation
WalkthroughThe changes reflect an update in the Eclipse-based project's configuration and dependencies. Key adjustments include the reorganization of template-related bundles and an update to the target platform URLs, aligning with newer releases of Eclipse and its components. This suggests an effort to stay current with the Eclipse ecosystem and possibly to leverage new features or fixes from the updated versions. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (2)
- releng/com.espressif.idf.configuration/pom.xml
- releng/com.espressif.idf.update/category.xml
Files selected for processing (2)
- bundles/com.espressif.idf.ui/META-INF/MANIFEST.MF (2 hunks)
- releng/com.espressif.idf.target/com.espressif.idf.target.target (2 hunks)
Files skipped from review due to trivial changes (1)
- releng/com.espressif.idf.target/com.espressif.idf.target.target
Additional comments: 2
bundles/com.espressif.idf.ui/META-INF/MANIFEST.MF (2)
42-46: The addition of new dependencies in the
MANIFEST.MF
file appears to be correct and aligns with the objective of supporting Eclipse 4.30. Ensure that these new dependencies (org.eclipse.epp.mpc.ui
,org.eclipse.tools.templates.core
,org.eclipse.tools.templates.ui
,org.freemarker.freemarker
,org.eclipse.tools.templates.freemarker
) are compatible with the rest of the project and that their versions are managed appropriately if required.36-49: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [1-49]
Given the nature of the changes to the
MANIFEST.MF
file, it is crucial to perform thorough testing of the plugin's functionality within Eclipse 4.30 to ensure that all features work as expected and that there are no integration issues with the new dependencies.
Hi @AndriiFilippov I have verified on the following scenarios and seems to be working fine. Espressif-IDE v2.11.1 + Update with this PR + Create a new project + build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kolipakakondal hi ! Tested under: Windows 10 Espressif-IDE from this PR + Create a new project + build able to install, build, flash, monitor 👍 |
@AndriiFilippov I further verified on Eclipse 2023-09 with this PR update site file, and it seems to be working fine. I will go ahead with the merge and will consider this for v2.12.0 release |
Description
Add support for Eclipse 4.30(Eclipse 2023-12)
Fixes # (IEP-1132)
Type of change
How has this been tested?
Test Configuration:
Dependent components impacted by this PR:
As this is a new Eclipse, we need to verify all the functionality
Checklist
Summary by CodeRabbit
Refactor
Chores