Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Eclipse 4.30(Eclipse 2023-12) #869

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

kolipakakondal
Copy link
Collaborator

@kolipakakondal kolipakakondal commented Dec 13, 2023

Description

Add support for Eclipse 4.30(Eclipse 2023-12)

Fixes # (IEP-1132)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How has this been tested?

Test Configuration:

  • ESP-IDF Version: master
  • OS (Windows,Linux and macOS): macOS

Dependent components impacted by this PR:

As this is a new Eclipse, we need to verify all the functionality

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

  • Refactor

    • Updated dependencies related to template management and freemarker integration.
  • Chores

    • Upgraded repository URLs in the project configuration to align with the latest Eclipse updates.

Copy link

coderabbitai bot commented Dec 13, 2023

Walkthrough

The changes reflect an update in the Eclipse-based project's configuration and dependencies. Key adjustments include the reorganization of template-related bundles and an update to the target platform URLs, aligning with newer releases of Eclipse and its components. This suggests an effort to stay current with the Eclipse ecosystem and possibly to leverage new features or fixes from the updated versions.

Changes

Files Change Summary
bundles/com.espressif.idf.ui/META-INF/MANIFEST.MF Updated Require-Bundle section, with removals and additions of template and freemarker related dependencies.
releng/.../com.espressif.idf.target.target Updated repository URLs in <location> elements from Eclipse 4.28 to 4.30 and from Eclipse releases 2023-09 to 2023-12.

🐇✨
In the realm of code, where the Eclipse lies,
A rabbit hopped through, with a twinkle in its eyes.
"Update and align," it whispered with cheer,
"For progress and growth, a new dawn is near!" 🌅🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 56a50d6 and 39555a8.
Files ignored due to filter (2)
  • releng/com.espressif.idf.configuration/pom.xml
  • releng/com.espressif.idf.update/category.xml
Files selected for processing (2)
  • bundles/com.espressif.idf.ui/META-INF/MANIFEST.MF (2 hunks)
  • releng/com.espressif.idf.target/com.espressif.idf.target.target (2 hunks)
Files skipped from review due to trivial changes (1)
  • releng/com.espressif.idf.target/com.espressif.idf.target.target
Additional comments: 2
bundles/com.espressif.idf.ui/META-INF/MANIFEST.MF (2)
  • 42-46: The addition of new dependencies in the MANIFEST.MF file appears to be correct and aligns with the objective of supporting Eclipse 4.30. Ensure that these new dependencies (org.eclipse.epp.mpc.ui, org.eclipse.tools.templates.core, org.eclipse.tools.templates.ui, org.freemarker.freemarker, org.eclipse.tools.templates.freemarker) are compatible with the rest of the project and that their versions are managed appropriately if required.

  • 36-49: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [1-49]

Given the nature of the changes to the MANIFEST.MF file, it is crucial to perform thorough testing of the plugin's functionality within Eclipse 4.30 to ensure that all features work as expected and that there are no integration issues with the new dependencies.

@kolipakakondal
Copy link
Collaborator Author

kolipakakondal commented Dec 13, 2023

Hi @AndriiFilippov I have verified on the following scenarios and seems to be working fine.

Espressif-IDE v2.11.1 + Update with this PR + Create a new project + build
Espressif-IDE from this PR + Create a new project + build

Copy link
Collaborator

@sigmaaa sigmaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndriiFilippov
Copy link
Collaborator

@kolipakakondal hi !

Tested under:

Windows 10
Eclipse: 23-12
ESP-IDF: v5.1.2

Espressif-IDE from this PR + Create a new project + build

able to install, build, flash, monitor 👍

@kolipakakondal
Copy link
Collaborator Author

@AndriiFilippov I further verified on Eclipse 2023-09 with this PR update site file, and it seems to be working fine.

I will go ahead with the merge and will consider this for v2.12.0 release

@kolipakakondal kolipakakondal added this to the v2.12.0 milestone Dec 13, 2023
@kolipakakondal kolipakakondal merged commit c5c998f into master Dec 13, 2023
5 of 7 checks passed
@kolipakakondal kolipakakondal deleted the IEP-1132 branch December 13, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants