-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IEP-922 Original Launch Configuration disappears after creating the new one. #851
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,6 @@ | |
|
||
import java.util.HashMap; | ||
import java.util.Map; | ||
import java.util.Map.Entry; | ||
|
||
import org.eclipse.cdt.debug.core.ICDTLaunchConfigurationConstants; | ||
import org.eclipse.cdt.debug.core.launch.CoreBuildGenericLaunchConfigProvider; | ||
|
@@ -11,12 +10,9 @@ | |
import org.eclipse.core.runtime.CoreException; | ||
import org.eclipse.debug.core.ILaunchConfiguration; | ||
import org.eclipse.debug.core.ILaunchConfigurationWorkingCopy; | ||
import org.eclipse.launchbar.core.ILaunchBarManager; | ||
import org.eclipse.launchbar.core.ILaunchDescriptor; | ||
import org.eclipse.launchbar.core.target.ILaunchTarget; | ||
|
||
import com.espressif.idf.core.IDFCorePlugin; | ||
|
||
public class IDFCoreLaunchConfigProvider extends CoreBuildGenericLaunchConfigProvider | ||
{ | ||
|
||
|
@@ -31,15 +27,9 @@ public ILaunchConfiguration getLaunchConfiguration(ILaunchDescriptor descriptor, | |
IProject project = descriptor.getAdapter(IProject.class); | ||
if (project != null) | ||
{ | ||
Map<String, ILaunchConfiguration> projectConfigs = configs.get(project); | ||
if (projectConfigs == null) | ||
{ | ||
projectConfigs = new HashMap<>(); | ||
configs.put(project, projectConfigs); | ||
} | ||
|
||
String targetConfig = descriptor.getName(); | ||
configuration = projectConfigs.get(targetConfig); | ||
configuration = configs.computeIfAbsent(project, key -> new HashMap<>()).get(targetConfig); | ||
if (configuration == null) | ||
{ | ||
// do we already have one with the descriptor? | ||
|
@@ -48,7 +38,7 @@ public ILaunchConfiguration getLaunchConfiguration(ILaunchDescriptor descriptor, | |
{ | ||
configuration = createLaunchConfiguration(descriptor, target); | ||
} | ||
projectConfigs.put(configuration.getName(), configuration); | ||
configs.get(project).put(configuration.getName(), configuration); | ||
} | ||
} | ||
return configuration; | ||
|
@@ -81,43 +71,12 @@ public boolean launchConfigurationAdded(ILaunchConfiguration configuration) thro | |
} | ||
if (configuration.exists()) | ||
{ | ||
Map<String, ILaunchConfiguration> projectConfigs = configs.get(project); | ||
if (projectConfigs == null) | ||
{ | ||
projectConfigs = new HashMap<>(); | ||
configs.put(project, projectConfigs); | ||
} | ||
|
||
projectConfigs.put(configuration.getName(), configuration); | ||
configs.computeIfAbsent(project, key -> new HashMap<>()).put(configuration.getName(), configuration); | ||
} | ||
Comment on lines
71
to
75
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
|
||
return ownsLaunchConfiguration(configuration); | ||
} | ||
|
||
@Override | ||
public boolean launchConfigurationRemoved(ILaunchConfiguration configuration) throws CoreException | ||
{ | ||
ILaunchBarManager launchBarManager = IDFCorePlugin.getService(ILaunchBarManager.class); | ||
for (Entry<IProject, Map<String, ILaunchConfiguration>> projectEntry : configs.entrySet()) | ||
{ | ||
Map<String, ILaunchConfiguration> projectConfigs = projectEntry.getValue(); | ||
for (Entry<String, ILaunchConfiguration> entry : projectConfigs.entrySet()) | ||
{ | ||
if (configuration.equals(entry.getValue())) | ||
{ | ||
projectConfigs.remove(entry.getKey()); | ||
if (projectConfigs.isEmpty()) | ||
{ | ||
configs.remove(projectEntry.getKey()); | ||
launchBarManager.launchObjectRemoved(projectEntry.getKey()); | ||
} | ||
return true; | ||
} | ||
} | ||
} | ||
return false; | ||
} | ||
|
||
@Override | ||
public boolean launchConfigurationChanged(ILaunchConfiguration configuration) throws CoreException | ||
{ | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
computeIfAbsent
method is used to simplify the initialization and retrieval of launch configurations. This is a good use of Java 8'sMap
API and improves the readability of the code.