Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run precommit Hook on pull_request #816

Merged
merged 1 commit into from
Sep 5, 2023
Merged

ci: Run precommit Hook on pull_request #816

merged 1 commit into from
Sep 5, 2023

Conversation

kolipakakondal
Copy link
Collaborator

@kolipakakondal kolipakakondal commented Sep 5, 2023

Description

Please include a summary of the change and which issue is fixed.

Fixes # (IEP-XXX)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • Component 1
  • Component 2

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

  • Chore: Added a new GitHub Actions workflow for pre-commit hooks. This workflow is triggered on pull requests to the master branch, ensuring that all code changes are validated before they are merged. It sets up Python 3.9, installs the pre-commit package, and runs the pre-commit hook against all files. This change enhances the code quality by enforcing checks before code merges.

@coderabbitai
Copy link

coderabbitai bot commented Sep 5, 2023

Walkthrough

This change introduces a GitHub Actions workflow for pre-commit hooks. It's designed to run on pull requests targeting the master branch, setting up Python 3.9, installing the pre-commit package, and executing the pre-commit hook across all files.

Changes

File Summary
.github/workflows/pre-commit.yml Adds a GitHub Actions workflow for pre-commit hooks. The workflow is triggered on pull requests to the master branch, sets up Python 3.9, installs pre-commit, and runs the pre-commit hook on all files.

🐇

In the land of code where the shadows lie,

A rabbit hops, its gaze held high.

With each commit, it takes a peek,

Ensuring the code is never weak.

Through Python's charm and GitHub's might,

Our code now shines in the brightest light! 🌟


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance. The bot stays silent unless called upon.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between fb53f00 and 91071d7 commits.
Files selected for processing (1)
  • .github/workflows/pre-commit.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/pre-commit.yml

@kolipakakondal kolipakakondal merged commit 9d6c775 into master Sep 5, 2023
4 checks passed
@kolipakakondal kolipakakondal deleted the precommit branch September 5, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant