-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH #798: At execution Espressif-IDE getting 'Cannot invoke "org.eclipse.debug.core.ILaunchConfiguration.getType()" because "configuration" is null' #804
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added test coverage for ActiveLaunchConfigurationProvider and optimization for IDFBuildConfiguration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...m.espressif.idf.core/src/com/espressif/idf/core/build/ActiveLaunchConfigurationProvider.java
Show resolved
Hide resolved
Optional<Job> launchBarInitJob = Stream.of(jobs) | ||
.filter(job -> job.getName() | ||
.equals(org.eclipse.launchbar.core.internal.Messages.LaunchBarManager_0)) | ||
.findAny(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can avoid referencing internal classes and messages if possible. In this case if we can copy the message and compare it directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kolipakakondal, thanks for your feedback. In this case, we rely on this message because it's the name of the Job, so if this message is changed on the eclipse side, this code just won't work and we won't know about it
Hi @sigmaaa ! Tested under: OS - Windows 10 Test 1 👍 Do not see "At execution Espressif-IDE getting 'Cannot invoke "org.eclipse.debug.core.ILaunchConfiguration.getType()" because "configuration" is null'" error, but see this one (probably my local issue):
|
Hi @sigmaaa Please verify @AndriiFilippov comments and see if that's an issue. I've merging this PR since I have NPE issue while adding clang toolchain |
Description
The problem was that LaunchBarManager could return null because it was not yet initialized during the eclipse starting phase.
Fixes # (IEP-1002)
Type of change
Please delete options that are not relevant.
How has this been tested?
Test 1
Test 2
Test Configuration:
Dependent components impacted by this PR:
Checklist