IEP-982 Test coverage for HintsUtil #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigmaaa
commented
Jul 10, 2023
|
|
||
| File hintsYmFile = new File(getHintsYmlPath()); | ||
| public static List<ReHintPair> getReHintsList(File hintsYmFile) |
There was a problem hiding this comment.
had to change the API for testing
| @Test | ||
| void getReHintsList_returns_correct_parsed_list() | ||
| { | ||
| final String expectedFirstHint = "The parameter type of the function esp_secure_boot_read_key_digests() has been changed from ets_secure_boot_key_digests_t* to esp_secure_boot_key_digests_t*."; |
There was a problem hiding this comment.
such a long string doesn't look pretty but maybe is acceptable in test classes. Or we could introduce Activator for the test plugin and introduce a messages class for such test string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added test coverage for HintsUtil class
Fixes # (IEP-982)
Type of change
Please delete options that are not relevant.
How has this been tested?
Test Configuration:
Dependent components impacted by this PR:
Checklist