IEP-976 Test coverage for BigIntDecoder #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigmaaa
commented
Jun 9, 2023
| @@ -45,7 +45,7 @@ else if (stringToDecode.startsWith("0", index) && stringToDecode.length() > 1 + | |||
| } | |||
|
|
|||
| return hasSign ? new BigInteger(firstChar + stringToDecode.substring(index), radix) | |||
| : new BigInteger(stringToDecode.substring(index)); | |||
| : new BigInteger(stringToDecode.substring(index), radix); | |||
There was a problem hiding this comment.
the bug was here. Without radix, we can't parse hex, oct values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added test coverage for BigIntDecoder class. Also, during the test I found bug, so I fixed it in this PR. The bug was in the incorrect decoding of hex, and octal values without a sign.
Fixes # (IEP-976)
Type of change
Please delete options that are not relevant.
How has this been tested?
BigIntDecoder is using for validating data in the NVS table, so to test it:
Test Configuration:
Dependent components impacted by this PR:
Checklist