Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #776

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Conversation

AndriiFilippov
Copy link
Collaborator

add "common error during installation" subtopic.

Description

The added hints will speed up the setup process.

Type of change

Please delete options that are not relevant.

  • documentation update

How has this been tested?

During installation

Test Configuration:

  • ESP-IDF Version: master
  • OS (Windows,Linux and macOS): Windows 10 / Linux Ubuntu

Copy link
Collaborator

@sigmaaa sigmaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@alirana01 alirana01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But need to rerun the build first before merge

add "common error during installation" subtopic
@kolipakakondal kolipakakondal merged commit 2c6dc03 into espressif:master Jul 5, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants