Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IEP-969 Test coverage for ZipUtility #774

Merged
merged 3 commits into from
Jul 4, 2023
Merged

IEP-969 Test coverage for ZipUtility #774

merged 3 commits into from
Jul 4, 2023

Conversation

sigmaaa
Copy link
Collaborator

@sigmaaa sigmaaa commented May 29, 2023

Description

Test coverage for ZipUtility class
Fixes # (IEP-969)

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

run junit tests

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

junit tests

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Copy link
Collaborator

@alirana01 alirana01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sigmaaa LGTM!
Just one small thing that maybe you can investigate or know already, if zip contains link files as tar.xz or gz we should have some tests for those I remember from the tools installation wizard that some of these zip files that were a link to another file either hard or soft given that file was also present in the archive were getting extracted as zero byte file. Not sure if zip has the same thing or not but worth looking at it. Also maybe we can move that archive decompression in tools installation wizard here. What do you think?

@sigmaaa
Copy link
Collaborator Author

sigmaaa commented Jun 23, 2023

Hi @sigmaaa LGTM! Just one small thing that maybe you can investigate or know already, if zip contains link files as tar.xz or gz we should have some tests for those I remember from the tools installation wizard that some of these zip files that were a link to another file either hard or soft given that file was also present in the archive were getting extracted as zero byte file. Not sure if zip has the same thing or not but worth looking at it. Also maybe we can move that archive decompression in tools installation wizard here. What do you think?

Hi, @alirana01, thanks for the review. I'll take a look into this

@kolipakakondal kolipakakondal merged commit cb7532c into master Jul 4, 2023
@kolipakakondal kolipakakondal deleted the IEP-969 branch July 4, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants