Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

porting: use macros for log level filtering #6

Closed
wants to merge 1 commit into from
Closed

porting: use macros for log level filtering #6

wants to merge 1 commit into from

Conversation

xentec
Copy link

@xentec xentec commented Apr 15, 2020

This reduces the size of the compiled binary by 7856 bytes.

@CLAassistant
Copy link

CLAassistant commented Apr 15, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@xentec
porting: use macros for log level filtering
cc1a5a5 
This reduces the size of the compiled binary by 7856 bytes.
zacwbond pushed a commit to bigassdata/esp-nimble that referenced this pull request Apr 15, 2020
@sjanc
nimble/ll: Fix assert in extended scanner
3c9e302 
It is possible that scheduler already fired and aux data is NULL so
we should unref it only if scheduler item was removed.

ble_ll_scan_aux_data_unref (aux_data=<optimized out>) at repos/apache-mynewt-nimble/nimble/controller/src/ble_ll_scan.c:1079
1079        BLE_LL_ASSERT(aux_data);
(gdb) bt
 #0  ble_ll_scan_aux_data_unref (aux_data=<optimized out>) at repos/apache-mynewt-nimble/nimble/controller/src/ble_ll_scan.c:1079
 espressif#1  0x0001f732 in ble_ll_scan_rx_pkt_in_on_aux (pdu_type=<optimized out>, om=0x2000d6f8 <os_msys_1_data>, hdr=0x2000d710 <os_msys_1_data+24>, addrd=addrd@entry=0x20004ecc <g_ble_ll_stack+404>)
    at repos/apache-mynewt-nimble/nimble/controller/src/ble_ll_scan.c:3156
 espressif#2  0x0002010e in ble_ll_scan_rx_pkt_in (ptype=ptype@entry=7 '\a', om=om@entry=0x2000d6f8 <os_msys_1_data>, hdr=hdr@entry=0x2000d710 <os_msys_1_data+24>)
    at repos/apache-mynewt-nimble/nimble/controller/src/ble_ll_scan.c:3198
 espressif#3  0x0001299e in ble_ll_rx_pkt_in () at repos/apache-mynewt-nimble/nimble/controller/src/ble_ll.c:837
 espressif#4  0x000129de in ble_ll_event_rx_pkt (ev=<optimized out>) at repos/apache-mynewt-nimble/nimble/controller/src/ble_ll.c:1164
 espressif#5  0x00012830 in ble_npl_event_run (ev=<optimized out>) at repos/apache-mynewt-nimble/porting/npl/mynewt/include/nimble/nimble_npl_os.h:116
 espressif#6  ble_ll_task (arg=<optimized out>) at repos/apache-mynewt-nimble/nimble/controller/src/ble_ll.c:1214
 espressif#7  0x00038e9c in nrf52_clock_hfxo_release () at repos/apache-mynewt-core/hw/mcu/nordic/nrf52xxx/include/mcu/cortex_m4.h:37
 espressif#8  0x00000000 in ?? ()
@dhrishi
Copy link
Collaborator

dhrishi commented Apr 20, 2020

@xentec Thanks for the contribution. We will review this PR and get back to you.

@prasad-alatkar
Copy link

LGTM

@dhrishi dhrishi requested a review from mahavirj April 21, 2020 09:30
@dhrishi dhrishi self-assigned this Apr 21, 2020
@dhrishi
Copy link
Collaborator

dhrishi commented Apr 21, 2020

@xentec This looks great! We will get this merged.

@xentec
Copy link
Author

xentec commented Apr 22, 2020

Nice. Thanks!

dhrishi pushed a commit that referenced this pull request May 20, 2020
@xentec @prasad-alatkar
porting: use macros for log level filtering
ee85711 
This reduces the size of the compiled binary by 7856 bytes.

Merges #6
dhrishi pushed a commit that referenced this pull request May 20, 2020
@xentec @prasad-alatkar
porting: use macros for log level filtering
39d67e3 
This reduces the size of the compiled binary by 7856 bytes.

Merges #6
espressif-bot pushed a commit to espressif/esp-idf that referenced this pull request May 22, 2020
@prasad-alatkar @espressif-bot
NimBLE: Include upstream fixes and use macros for log level filtering
2ef4890 
Change list:
- Reduces the size of the compiled binary, PR: espressif/esp-nimble#6
- Null pointer check, PR: apache/mynewt-nimble#701
- Pairing procedure abort on unexpected req: apache/mynewt-nimble#710
- Fix conn flags after pairing: apache/mynewt-nimble#730
- Remove notification for update process timeout (Vol 6, Part B, section 5.2 ):
  apache/mynewt-nimble#782
- CCCD fix : apache/mynewt-nimble#790 and
  apache/mynewt-nimble#804
- Host based Privacy (RPA) fix: espressif/esp-nimble#7

 Closes espressif/esp-nimble#10

 Closes #4413
dhrishi pushed a commit that referenced this pull request May 28, 2020
@xentec @prasad-alatkar
porting: use macros for log level filtering
e0d8b78 
This reduces the size of the compiled binary by 7856 bytes.

Merges #6
@prasad-alatkar
Copy link

Hi @xentec the changes are included in esp-nimble, commit: 6d65906 . I cherry-picked your commit in my existing MR, that is why the commit SHA is changed, and I suppose that may be the reason the PR has not been marked as merged. Nevertheless your contribution is visible in commit history. Thank you for your contribution.

@xentec xentec closed this May 29, 2020
mahavirj pushed a commit to mahavirj/esp-afr-sdk that referenced this pull request Jun 1, 2020
@prasad-alatkar
NimBLE: Include upstream fixes and use macros for log level filtering…
04e3cf4 
… (backport v3.3)

Change list:
- Reduces the size of the compiled binary, PR: espressif/esp-nimble#6
- Null pointer check, PR: apache/mynewt-nimble#701
- Pairing procedure abort on unexpected req: apache/mynewt-nimble#710
- Fix conn flags after pairing: apache/mynewt-nimble#730
- Remove notification for update process timeout (Vol 6, Part B, section 5.2 ):
  apache/mynewt-nimble#782
- CCCD fix : apache/mynewt-nimble#790 and
  apache/mynewt-nimble#804
- Host based Privacy (RPA) fix: espressif/esp-nimble#7

 Closes espressif/esp-nimble#10

 Closes espressif/esp-idf#4413
@xentec xentec deleted the patch-1 branch June 8, 2020 23:56
espressif-bot pushed a commit to espressif/esp-idf that referenced this pull request Jun 15, 2020
@prasad-alatkar
NimBLE: Include upstream fixes and use macros for log level filtering…
5af06f4 
… (backport v4.0)

Change list:
- Reduces the size of the compiled binary, PR: espressif/esp-nimble#6
- Null pointer check, PR: apache/mynewt-nimble#701
- Pairing procedure abort on unexpected req: apache/mynewt-nimble#710
- Fix conn flags after pairing: apache/mynewt-nimble#730
- Remove notification for update process timeout (Vol 6, Part B, section 5.2 ):
  apache/mynewt-nimble#782
- CCCD fix : apache/mynewt-nimble#790 and
  apache/mynewt-nimble#804
- Host based Privacy (RPA) fix: espressif/esp-nimble#7

 Closes espressif/esp-nimble#10

 Closes #4413
projectgus pushed a commit to espressif/esp-idf that referenced this pull request Jul 22, 2020
@prasad-alatkar
NimBLE: Include upstream fixes and use macros for log level filtering…
3db186d 
… (backport v4.1)

Change list:
- Reduces the size of the compiled binary, PR: espressif/esp-nimble#6
- Null pointer check, PR: apache/mynewt-nimble#701
- Pairing procedure abort on unexpected req: apache/mynewt-nimble#710
- Fix conn flags after pairing: apache/mynewt-nimble#730
- Remove notification for update process timeout (Vol 6, Part B, section 5.2 ):
  apache/mynewt-nimble#782
- CCCD fix : apache/mynewt-nimble#790 and
  apache/mynewt-nimble#804
- Host based Privacy (RPA) fix: espressif/esp-nimble#7

 Closes espressif/esp-nimble#10

 Closes #4413
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahavirj mahavirj mahavirj approved these changes

Assignees

@dhrishi dhrishi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xentec @CLAassistant @dhrishi @prasad-alatkar @mahavirj