Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: esp_wifi_set_promiscuous_filter() vs. esp_wifi_set_promiscuous_ctrl_filter() (IDFGH-9366) #10740

Closed
3 tasks done
roger- opened this issue Feb 10, 2023 · 1 comment
Assignees
Labels
Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally

Comments

@roger-
Copy link

roger- commented Feb 10, 2023

Answers checklist.

  • I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
  • I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
  • I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report

The documentation on esp_wifi_set_promiscuous_filter() and esp_wifi_set_promiscuous_ctrl_filter() could use some improvement:

  • what does "filter" mean? Block or pass? "Filter" by itself seems ambiguous.
  • the relationship between the two functions is not clear. Does esp_wifi_set_promiscuous_filter() need to be called with the WIFI_PROMIS_FILTER_MASK_CTRL option before esp_wifi_set_promiscuous_ctrl_filter()?
  • what happens if you just call esp_wifi_set_promiscuous_ctrl_filter()?
@espressif-bot espressif-bot added the Status: Opened Issue is new label Feb 10, 2023
@github-actions github-actions bot changed the title Documentation: esp_wifi_set_promiscuous_filter() vs. esp_wifi_set_promiscuous_ctrl_filter() Documentation: esp_wifi_set_promiscuous_filter() vs. esp_wifi_set_promiscuous_ctrl_filter() (IDFGH-9366) Feb 10, 2023
@zhangyanjiaoesp
Copy link
Collaborator

@roger-

what does "filter" mean? Block or pass? "Filter" by itself seems ambiguous.

The documentation already says "filter" means "pass".

If the sniffer mode is enabled, the following packets can be dumped to the application.

For frames that the sniffer can dump, the application can additionally decide which specific type of packets can be filtered to the application by using esp_wifi_set_promiscuous_filter() and esp_wifi_set_promiscuous_ctrl_filter().

https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/wifi.html#wi-fi-sniffer-mode

For the relationship between the two functions, we will update the documentation.

@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Opened Issue is new Status: Reviewing Issue is being reviewed labels Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

No branches or pull requests

3 participants