Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

LLD linker fixes #52

Merged
merged 1 commit into from
Jan 23, 2023
Merged

LLD linker fixes #52

merged 1 commit into from
Jan 23, 2023

Conversation

MabezDev
Copy link
Member

@MabezDev MabezDev commented Jan 18, 2023

GNU LD automatically makes direct assignments relative to the current section, i.e . = 4 means move the location counter to offset 4 in the current section. LLD does not share this behaviour: https://bugs.llvm.org/show_bug.cgi?id=41169.

To support both LLD and GNU LD we need to rewrite our vectors linker script to not rely on such behaviour which this commit does.

GNU LD automatically makes direct assignments relative to the current
section, i.e `. = 4` means move the location counter to offset 4 in the
_current section_. LLD does not share this behavior:
https://bugs.llvm.org/show_bug.cgi?id=41169.

To support both LLD and GNU LD we need to rewrite our vectors linker
script to not rely on such behavior which this commit does.
@MabezDev MabezDev marked this pull request as ready for review January 23, 2023 14:07
@MabezDev MabezDev requested a review from bjoernQ January 23, 2023 14:08
@MabezDev
Copy link
Member Author

I now have esp-hal working with LLD, the changes in this PR also need to be applied to esp-hal (as well as some others). This should be good to go.

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I can only imagine the "fun" to find out this

@MabezDev MabezDev merged commit 7324ef0 into master Jan 23, 2023
@MabezDev MabezDev mentioned this pull request Jan 23, 2023
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants