Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows exports #111

Merged
merged 2 commits into from
Dec 23, 2022
Merged

Fix Windows exports #111

merged 2 commits into from
Dec 23, 2022

Conversation

SergioGasquez
Copy link
Member

  • Windows export file now only contains \ instead of mixing / and \.
  • GCC paths are now exported between " for Unix.

@SergioGasquez SergioGasquez linked an issue Dec 23, 2022 that may be closed by this pull request
@SergioGasquez
Copy link
Member Author

Please @georgik, can you verify that we solve #97 with this PR? You can use the Windows artifact achieved from the CI

@georgik
Copy link
Contributor

georgik commented Dec 23, 2022

@SergioGasquez Perfect. It works:

$Env:PATH += ";C:\Espressif\tools\xtensa-esp32s2-elf\esp-2021r2-patch5-8_4_0\xtensa-esp32s2-elf\bin"
$Env:PATH += ";C:\Espressif\tools\xtensa-esp32s3-elf\esp-2021r2-patch5-8_4_0\xtensa-esp32s3-elf\bin"
$Env:PATH += ";C:\Espressif\tools\xtensa-esp32-elf\esp-2021r2-patch5-8_4_0\xtensa-esp32-elf\bin"
$Env:PATH += ";C:\Espressif\tools\riscv32-esp-elf\esp-2021r2-patch5-8_4_0\riscv32-esp-elf\bin"
$Env:LIBCLANG_PATH="C:\Espressif\tools\xtensa-esp32-elf-clang\esp-15.0.0-20221201-x86_64-pc-windows-msvc\esp-clang\bin\libclang.dll"
$Env:PATH+=";C:\Espressif\tools\xtensa-esp32-elf-clang\esp-15.0.0-20221201-x86_64-pc-windows-msvc\esp-clang\bin"

@SergioGasquez SergioGasquez merged commit 299494e into main Dec 23, 2022
@SergioGasquez SergioGasquez deleted the fix/windows-exports branch December 23, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows - export-esp.ps1 contains path with mixed / and \
2 participants