Unify configuration methods

[SergioGasquez]

• Checks for config file in:

  • <current_folder>/.config/espflash.toml
    • Not sure if this is the best path. Maybe other option could be reusing .cargo/config.toml as its present in most(or all) our project.
  • <config_dir>/espflash/espflash.toml

• Supports the following configurations:

  • Preferred serial and usb connections
    • If we set the ESPFLASH_PORT it will be used instead of the config file value
  • Bootloader
  • Partition table
  • Baudrate
    • If we set the ESPFLASH_BAUD it will be used instead of the config file value

• [cargo-espflash]: We no longer support setting bootloader, format and partition table in cargo metadata

[MabezDev]

<current_folder>/.config/espflash.toml

What's the rationale around having it inside <current_dir>/.config, instead of <current_dir>? It doesn't matter much to me, but I just wonder if there is a particular reason. Most other tools with configs, namely probe-rs (cargo embed) place there configuration files in the root of the project.

[MabezDev]

Could you remind me again what this is? I don't use cargo-espflash very often 😅.

[SergioGasquez]

You could set the partition-table, bootloader and format in the package metadata, see https://github.com/esp-rs/espflash/tree/main/cargo-espflash#package-metadata. At the moment, I removed baudrate and partition-table properties. IMHO, we can also remove the format

[MabezDev]

Ah, I see, thanks! Yes lets remove format too.

[SergioGasquez]

What's the rationale around having it inside <current_dir>/.config, instead of <current_dir>? It doesn't matter much to me, but I just wonder if there is a particular reason. Most other tools with configs, namely probe-rs (cargo embed) place there configuration files in the root of the project.

Tbh, I just followed the suggestion in #469, I can update the path to be <current_dir>

[MabezDev]

imo it should probably be in the current directory, but I'll let @jessebraham @bjoernQ and @JurajSadel weigh in too.

[SergioGasquez]

imo it should probably be in the current directory, but I'll let @jessebraham @bjoernQ and @JurajSadel weigh in too.

Awesome, let's hear their opinion, I am happy to change it with whatever we decide

[bjoernQ]

I think I would prefer the current directory

[jessebraham]

Sorry if I've missed something, why was the Cargo package metadata loading in cargo-espflash crippled? What's the point of even having it in its current rendition?

[SergioGasquez]

Sorry if I've missed something, why was the Cargo package metadata loading in cargo-espflash crippled? What's the point of even having it in its current rendition?

I'd say we can remove the Cargo metadata, as it is now in the config file and its the same for espflash/cargo-espflash

[jessebraham]

That's disappointing, I use it in most of my projects :/ Guess I will switch over, thanks.

[SergioGasquez]

That's disappointing, I use it in most of my projects :/ Guess I will switch over, thanks.

I mean, we can keep it. No hard opinion there, but then we would have multiple ways of defining those configs.

[SergioGasquez]

I updated the local config to live under <current_dir>/espflash.toml, removed the format param from cargo metadata for cargo-espflash and udpated the docs

[bjoernQ]

Looks good to me

[JurajSadel]

LGTM