Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add min_chip_rev argument #525

Merged
merged 5 commits into from
Dec 21, 2023
Merged

Add min_chip_rev argument #525

merged 5 commits into from
Dec 21, 2023

Conversation

SergioGasquez
Copy link
Member

With these changes, when using the argument and specifying a --min-chip-rev greater that the chip revision you get:

     Running `/home/sergio/Documents/Espressif/forks/espflash/target/release/espflash flash --min-chip-rev 5 esp32c3`
[2023-11-30T15:26:40Z INFO ] Serial port: '/dev/ttyACM0'
[2023-11-30T15:26:40Z INFO ] Connecting...
[2023-11-30T15:26:40Z INFO ] Using flash stub
[2023-11-30T15:26:40Z WARN ] Setting baud rate higher than 115,200 can cause issues
Error: espflash::unsupported_chip_revision

  × Minimum supported revision is 5, connected device's revision is 3

@SergioGasquez SergioGasquez linked an issue Nov 30, 2023 that may be closed by this pull request
Add the ability to specify a minimum compatible revision number #370
Closed
bjoernQ
bjoernQ reviewed Dec 21, 2023
View reviewed changes
espflash/src/cli/mod.rs Outdated Show resolved Hide resolved
bjoernQ
bjoernQ reviewed Dec 21, 2023
View reviewed changes
espflash/src/cli/mod.rs Outdated Show resolved Hide resolved
bjoernQ
bjoernQ approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - works fine

@SergioGasquez SergioGasquez merged commit 77fd5b4 into esp-rs:main Dec 21, 2023
19 checks passed
@SergioGasquez SergioGasquez deleted the feat/min-chip-rev branch December 21, 2023 13:32
@SergioGasquez SergioGasquez mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the ability to specify a minimum compatible revision number
3 participants
@SergioGasquez @bjoernQ @jessebraham