Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the CI workflow #419

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Update the CI workflow #419

merged 1 commit into from
Jun 1, 2023

Conversation

jessebraham
Copy link
Member

  • Extracted an action to set up an ARM build environment to make the workflow simpler to read
  • All existing actions now run on ubuntu-22.04
  • We now additionally check the binary build on macos-12 and windows-22
  • The CI workflow files have been renamed to be consistent with other repos in the org

I like that the workflows now both follow the same structure and are fairly easy to grok. The downside is that we have a fair bit of duplicated YAML, but given how infrequently these files need changing IMO it's a worthwhile sacrifice.

@SergioGasquez if you have any feedback or opinions on this please let me know!

I will update the package workflows in a later PR.

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The CI now looks way better!

.github/actions/setup-arm/action.yml Outdated Show resolved Hide resolved
@jessebraham jessebraham merged commit 151ca29 into esp-rs:main Jun 1, 2023
@jessebraham jessebraham deleted the fixes/ci branch June 1, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants