limit default partition size #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some chips can have more than 16MB of flash, mine as 32MB. Historically espflash failed to detect this flash size but now can. Without this change the board will boot loop because the esp idf bootloader max size is only 16MB.
SergioGasquez
approved these changes
May 5, 2023
|
Tested this on my ESP32-S3 32MB flash, works fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some chips can have more than 16MB of flash, mine has 32MB. Historically espflash failed to detect this flash size (and defaulted to 4MB) but now it can. Without this change, the board will boot loop because the esp idf bootloader max size is only 16MB.
Closes #393