Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature "big-heap", fix calloc #155

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Feature "big-heap", fix calloc #155

merged 1 commit into from
Apr 6, 2023

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Apr 6, 2023

This is in preparation for mbedtls but probably also otherwise a good thing

  • fixes calloc
  • adds a feature big-heap
  • uses dram2 segment for the heap on ESP32 (but uses dram1 if there is no such segment)
  • fixes one example (ESP32-S3 access-point.rs)
  • makes init_heap private and calls it internally in initialize

@bjoernQ bjoernQ mentioned this pull request Apr 6, 2023
Closed
@bjoernQ bjoernQ requested a review from MabezDev April 6, 2023 13:54
MabezDev
MabezDev approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice to move the heap init into esp-wifi

@bjoernQ bjoernQ merged commit f79819d into main Apr 6, 2023
@bjoernQ bjoernQ deleted the fixes-and-features-for-mbedtls branch April 6, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernQ @MabezDev