Refactor examples #146
Merged
Refactor examples #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Obviously I forgot to change the CI workflows - converted into a draft PR for now |
MabezDev
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
examples-utilcrate to make the example code look a bit less scaryexamples-esp32XXfolder for each targetAll of the
examples-esp32XXcontain the exact same Rust code. In theory we could use symlinks but that would make things really hard for Windows users. So yes - this adds a lot of duplicate code but as long as we all know we just need to copy the same file in different locations it should be fine. We just shouldn't start to change the files individuallyAlso, those folders contain all the examples for all targets - even if it's not supported. IMHO it's easier to keep the files in sync this way and it's not worse than before since nothing was holding anyone back from trying to compile an example even if it's unsupported.
Closes #145