Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BTLE for ESP32-S3 #105

Merged
merged 1 commit into from
Jan 4, 2023
Merged

BTLE for ESP32-S3 #105

merged 1 commit into from
Jan 4, 2023

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Jan 2, 2023

  • implements BTLE support for ESP32-S3
  • fixes lld_pdu.c assertions running BLE example on esp32 chip #78 - not sure why not enabling the RWBLE interrupt fixes this but for me I haven't seen that assert triggered anymore
  • coex is implemented but only works in opt-level 1 (seems there are still mis-optimizations going on - no idea how to find out what the problem might be) ... that's why coex on ESP32-S3 isn't mentioned in the README

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Jan 3, 2023

@MabezDev I tried disabling loop optimization but that is not enough to get the coex example to work - only opt-level 1 makes it work (spoiler: I'm currently trying to update the drivers and with the new drivers none of the S3 examples work in opt-level 3 but disabling loop optimization makes at least ble and dhcp example work - but for coex still opt-level 1 is needed there)

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Works very well for me, the code looks okay to me too :).

I don't know what to suggest regarding the possible compiler issues, they don't seem to be present here (when not using coex) so I guess wait for the new PR to update the blobs and assess then?

@bjoernQ bjoernQ merged commit b7643e7 into main Jan 4, 2023
@bjoernQ bjoernQ deleted the esp32s3-ble branch January 4, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lld_pdu.c assertions running BLE example on esp32 chip
2 participants