Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes in INTERRUPT_CORE0 for ESP32-C6 #149

Closed
wants to merge 1 commit into from

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Aug 10, 2023

This will fix
esp-rs/esp-wifi-sys#228
esp-rs/esp-wifi-sys#228

Problem: There was LP_TOUCH_INTR_MAP added which changed all following register offsets.

While we don't use *_INTR_MAP we do use INTR_STATUS_X registers which are now off by 4 bytes.

While this PR will fix that (by reverting those changes in esp32c6/svd/esp32c6.base.svd directly (because patching all these offsets seems like an unnecessary chore)) I have no idea how to prevent this to become a problem again in future.

Since there were never patches for this, I assume we inherited this problem directly from upstream. I certainly can create a PR for https://github.com/espressif/svd but even then ... those SVDs have their source and I guess when they are re-generated we will get the same error in again

So .... no idea if we should merge this or if we need to do the changes at the very source?

At least without a fix for this we will not only break esp-wifi but also everything interrupt related for ESP32-C6

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! I don't know if this is best approach to solving this though, or if we should do it in the original SVDs, so I'll defer to @jessebraham

@jessebraham
Copy link
Member

There is a 100% chance I will forget about this and it will regress in the next SVD release, so closing in favour of #150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants