Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch RISC-V MSRV to nightly release channel #725

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

jessebraham
Copy link
Member

Since the release of log@0.4.19 broke our MSRV check, we had pinned this dependency to =0.4.18.

To resolve this, I've switched from the stable to the nightly release channel (it doesn't really make sense to use stable here, anyway...), using the version of nightly at which point the relevant release was branched from main. This allows us to un-pin the log dependency.

@jessebraham
Copy link
Member Author

(Forgot the stupid skip-changelog label AGAIN...)

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jessebraham jessebraham merged commit ae455ed into esp-rs:main Aug 15, 2023
15 of 16 checks passed
@jessebraham jessebraham deleted the fixes/msrv branch August 15, 2023 13:49
bugadani pushed a commit to bugadani/esp-hal that referenced this pull request Aug 20, 2023
* Use `nightly` release for MSRV check

* Un-pin the `log` package version
playfulFence pushed a commit to playfulFence/esp-hal that referenced this pull request Sep 26, 2023
* Use `nightly` release for MSRV check

* Un-pin the `log` package version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants