Implement calibrated ADC API for S3 #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
s3_calibration
branch
19 times, most recently
from
b8a3afd
to
5a89305
Compare
|
I would appreciate if someone who has the tools could test the example. I just picked some number out of thin air so it would be good to know if those are at least in the ballpark of reality. |
|
Code looks good to me and the raw values range also looks good. As you said would be good if someone with the appropriate equipment could verify the numbers |
bugadani
force-pushed
the
s3_calibration
branch
2 times, most recently
from
aff46bd
to
2686f05
Compare
|
I would appreciate if we could push this PR forward. The accuracy of the assumed VRef and other parameters may be improved later. The PR works well enough and the measured values are in the ballpark of reality (I just can't say for sure because my hardware's 1MOhm/1MOhm divider just doesn't play nice with the ADC's input impedance). |
MabezDev
approved these changes
Jul 24, 2023
playfulFence
pushed a commit
to playfulFence/esp-hal
that referenced
this pull request
Sep 26, 2023
* adc_cal: s3: Add efuse functions for reading calibration * Add changelog entry * Implement calibrated ADC API for S3 * adc_cal: s3: Add calibrated ADC reading example * Clean up * Prefer where clauses * Clean up unnecessary unsafe blocks * Fix autolinks --------- Co-authored-by: Scott Mabin <scott@mabez.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you!
Thank you for your contribution.
Please make sure that your submission includes the following:
Must
errorsorwarnings.cargo fmtwas run.CHANGELOG.mdin the proper section.Nice to have
This PR implements ADC calibration on top of #555 sor the S3. The PR also defines the constants for the S2, but does not implement the example, the efuse functions or calibration types.
cc #326