C3: ADC raw values calibration #550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on ESP32-C3 and I get the same values I get with the eps-idf example. (With |
katyo
reviewed
May 20, 2023
| @@ -59,4 +59,25 @@ impl Efuse { | |||
| let efuse = unsafe { &*EFUSE::ptr() }; | |||
| efuse.rd_repeat_data1.read().wdt_delay_sel().bits() | |||
| } | |||
|
|
|||
| /// Read Efuse data and return them | |||
| pub fn read_efuse(address: u32, offset: u32, size: u32) -> u32 { | |||
There was a problem hiding this comment.
Efuses also can be read via peripheral access like so:
let efuse = unsafe { &*EFUSE::ptr() };
efuse.rd_sys_part1_data0.read().bit_field()But seems currently bit fields isn't described.
(see registers definition in esp32c3.base.svd)
|
Is there anything else I need to do apart from using the branch to test this out? ADC values still don't show correct values:
|
|
Superseded by #555 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds initial ADC raw values calibration. The solution is ported from https://github.com/apache/nuttx/blob/master/arch/risc-v/src/esp32c3/esp32c3_adc.c
The
11dBattenuation seems to be working fine, however, other values(0, 2.5, and 6dB) are weird - I'm getting 4095(raw) for the default state (with11dBI'm getting ~2200(raw)). The weirdest thing here is that I have the same behavior in ESP-IDF oneshot example. I've tested with Rust board (C3, revision3) and 5V joystick.If anyone has any idea, what is going on with
attenuations(or can test this code) it'd be very appreciated.I'll look into calculating voltage from raw values in the meantime.
Related #326