-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for RSA in ESP32-H2 #526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really have an opinions on renaming the file, I guess it doesn't matter too much to me.
Could you add an entry to the CHANGELOG.md please?
Updated! Not sure how the workflow for updating it should be. Open a PR and then update the CHANGELOG, so we can add the PR number to it? |
Probably, yes! In theory you can also guess the next PR number if no one else submits a PR at the same moment in time |
Two options I see are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflicts need resolving but LGTM otherwise, thanks!
Just noticed there was some duplicated coded in the rsa examples of H2 and C6, just removed it in 8ee8a68 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* feat: ✨ Initial support for RSA * docs: 📝 Update docstring * docs: 📝 Update changelog * fix: 🔥 Remove duplicated code
* feat: ✨ Initial support for RSA * docs: 📝 Update docstring * docs: 📝 Update changelog * fix: 🔥 Remove duplicated code
Adds initial support for RSA and the
rsa
example.I've used the
rsa/esp32cX.rs
which I think should work for ESP32-H2 but not sure if we should update the name of it.Tested the
rsa
example and here is the output: