Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial support for the ESP32-H2 #513

Merged
merged 9 commits into from
May 9, 2023
Merged

Add initial support for the ESP32-H2 #513

merged 9 commits into from
May 9, 2023

Conversation

jessebraham
Copy link
Member

Not quite a "minimal" implementation, but not too far off either. Demonstrates basic functionality of the GPIO, TIMG, UART, and WDT peripherals, plus various other bits.

All included examples have been tested on hardware, though it wouldn't hurt to verify.

Thanks to @playfulFence and @SergioGasquez for the help with this!

jessebraham
jessebraham commented May 5, 2023
View reviewed changes
Copy link
Member Author

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to update the top-level README as well as the blinky example, will get those fixed.

esp32h2-hal/examples/blinky.rs Outdated Show resolved Hide resolved
@jessebraham
Copy link
Member Author

@playfulFence why did you push another commit to this branch? The CI was already green, I'm not sure I understand the need for the latest commit.

@playfulFence
Copy link
Contributor

@playfulFence why did you push another commit to this branch? The CI was already green, I'm not sure I understand the need for the latest commit.

@jessebraham I've tested direct-boot feature few more times on real HW and the conclusion is that it's buildable, but doesn't work properly. I thought, we shouldn't have it in the CI until it works.
We can roll back the change if my assumption is wrong

@jessebraham
Copy link
Member Author

Okay that's fine, thanks for clarifying. Last we spoke you had mentioned that you thought it worked, so just wanted to be sure about the reason for the change.

bjoernQ
bjoernQ approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

playfulFence and others added 9 commits May 8, 2023 08:03
@playfulFence @jessebraham
Started adding ESP32-H2 support (#482)
9493b38
@SergioGasquez @jessebraham
Add ESP32- H2 soc/efuse methods (#486)
854e52c 
* feat: ✨ Implement efuse methods

* feat: ✨ Add NUM_PINS

* doc: Update link to point at specific commit

Co-authored-by: Jesse Braham <jessebraham@users.noreply.github.com>

---------

Co-authored-by: Jesse Braham <jessebraham@users.noreply.github.com>
@jessebraham
Add initial ADC/GPIO implementation for ESP32-H2 (#494)
c3b4e83 
* Add `esp32h2-hal` package to the VS Code workspace and CI workflow

* Add initial (not quite complete) implementation of GPIO/ADC for ESP32-H2
@jessebraham
Add ESP32-H2 support for TIMG and UART (#500)
4e9e1d1 
* Begin working on `PeripheralClockControl` for the ESP32-H2

* Update `UART` driver to add H2 support

* Update `TIMG` driver to add H2 support

* Update the hello_world example to use `TIMG` and `UART`
@playfulFence @jessebraham
Added WDT support for ESP32-H2 (#511)
7d72acb 
* Added init function

* Populated enums

* Adding enums

* Add TODO (according to IDF update)

* Added WDT support for ESP32-H2

* Updated hello_world example

* Add two examples for both watchdog and RTC watchdog

* Add specific bit initialization for TIMG0 and TIMG1

* Cleaning the code

* adjusting for rustfmt

* uncommented direct-boot feature test in CI
@jessebraham
Fix build errors after rebasing
fc2dd38
@playfulFence @jessebraham
Update CI
ad0b4e4 
Comment direct-boot test, still only buildable, but requires fixes for Real HW
@jessebraham
Update the top-level README and CHANGELOG, fix blinky example
ca54d29
@jessebraham
Rebase branch, update rtc_cntl implementation, add rtc_time example
5de726f
@jessebraham
Copy link
Member Author

I've rebased this branch and added a commit reflecting the changes merged in #476

MabezDev
MabezDev approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DHL Finally delivered my boards! Working well here, just a warning when building, but I assume that'll get fixed in a follow up PR when we add that functionality :)

@jessebraham jessebraham merged commit c5d8cc6 into main May 9, 2023
@jessebraham jessebraham deleted the feature/esp32h2 branch May 9, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

@MabezDev MabezDev MabezDev approved these changes

@JurajSadel JurajSadel Awaiting requested review from JurajSadel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jessebraham @playfulFence @bjoernQ @MabezDev @SergioGasquez