Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP32-C3: Disable usb_pad_enable when setting GPIO18/19 to input/output #461

Merged
merged 1 commit into from
Mar 30, 2023
Merged

ESP32-C3: Disable usb_pad_enable when setting GPIO18/19 to input/output #461

merged 1 commit into from
Mar 30, 2023

Conversation

jessebraham
Copy link
Member

Fixes #279

JurajSadel
JurajSadel approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bjoernQ
Copy link
Contributor

bjoernQ commented Mar 30, 2023

LGTM but we should also do it for ESP32-S2, S3 and C6

@jessebraham
Copy link
Member Author

I had tested it on my S3 yesterday and the fix wasn't required, so between that and the issue title I kind of just assumed it was specific to the C3. I will test the other chips today though and see if they are affected.

@jessebraham
Copy link
Member Author

I just tested the C3, C6, S2, and S3; I modified blinky.rs from the main branch (without this fix) to use GPIO18 and all chips except the C3 worked as expected.

@bjoernQ
Copy link
Contributor

bjoernQ commented Mar 30, 2023

mhhh interesting ... probably I'll try to have a look at what esp-idf does there 🤷‍♂️
anyways since the PR is about C3 I am fine to merge it already

bjoernQ
bjoernQ approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessebraham jessebraham merged commit aa23536 into esp-rs:main Mar 30, 2023
@jessebraham jessebraham deleted the fixes/usb-gpio branch March 30, 2023 13:45
@jessebraham jessebraham mentioned this pull request Jul 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

@JurajSadel JurajSadel JurajSadel approved these changes

@MabezDev MabezDev Awaiting requested review from MabezDev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESP32C3: GPIO18 & 19 and JTAG USB
3 participants
@jessebraham @bjoernQ @JurajSadel