Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest PACs and make required changes #435

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

jessebraham
Copy link
Member

I'm leaving this as a draft for the time being because I have not yet published the PACs; I wanted to get some eyes on these changes first to make sure there aren't any other obvious changes to make along with these ones.

Changes to the SVDs/PACs are largely naming-related, where I tried to better align the names of the peripherals/interrupts across all devices. There may still be some discrepancies but I think we're in pretty good shape.

I've also bumped the versions of the nb and paste dependencies, as they've both had new releases and I was in there anyway.

@MabezDev @bjoernQ if you could take a look at this some time next week and let me know if you feel anything is missing I'd appreciate it! I will publish new PACs next week and update the status of this PR at that time.

@bjoernQ
Copy link
Contributor

bjoernQ commented Mar 10, 2023

Looks good to me! Less cfgs is always a good change 👍

@jessebraham jessebraham changed the title Use latest (unpublished) PACs and make required changes Use latest PACs and make required changes Mar 13, 2023
@jessebraham jessebraham marked this pull request as ready for review March 13, 2023 17:11
@jessebraham
Copy link
Member Author

This PR should be good to go now!

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

Only thing (but not necessarily for this PR):
ESP32 is still missing SW-interrupts (24-27) - I think more changes are planned for the SVD/PACs in near future so it is not really blocking this

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jessebraham jessebraham merged commit a0b72bd into esp-rs:main Mar 14, 2023
@jessebraham jessebraham deleted the fixes/update-pacs branch March 15, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants