Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the references to the ets_update_cpu_frequency_rom ROM function #374

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Fix the references to the ets_update_cpu_frequency_rom ROM function #374

merged 1 commit into from
Jan 31, 2023

Conversation

jessebraham
Copy link
Member

@jessebraham jessebraham commented Jan 31, 2023 •
edited
Loading

Closes #367 (I think 😁). It was already working on this system to begin with, I'll hop on my other computer in a bit and test it out there.

bjoernQ
bjoernQ approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Should do the trick - I guess we should call that on other targets as well since otherwise ROM functions like ets_delay won't work correctly but that's something for another day

@jessebraham
Copy link
Member Author

Tested on my other system and this seems to have resolved the linker error.

@jessebraham jessebraham merged commit 75f7394 into esp-rs:main Jan 31, 2023
@jessebraham jessebraham deleted the fixes/rom-functions branch January 31, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linker error with latest esp32c3-hal release
2 participants
@jessebraham @bjoernQ