Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DMA marker traits available to users #356

Merged
merged 3 commits into from
Jan 23, 2023
Merged

Make DMA marker traits available to users #356

merged 3 commits into from
Jan 23, 2023

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Jan 23, 2023

Fix #345
Fix #342

@bjoernQ bjoernQ requested a review from MabezDev January 23, 2023 12:11
@bjoernQ
Copy link
Contributor Author

bjoernQ commented Jan 23, 2023

There are also other things we might want to make available to users but I don't think we need to do that in a big-bang (but when we consider making things private which used to be public it might be more convenient to users to do that in a single PR)

MabezDev
MabezDev requested changes Jan 23, 2023
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but what about also putting the descriptor comment on the dma.configure() function, most people will use the docs for the function instead of the module level docs.

@MabezDev MabezDev merged commit 1ec6f98 into esp-rs:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Traits with private bounds. Document how to estimate the size of DMA descriptor arrays
2 participants
@bjoernQ @MabezDev