-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PSRAM in DmaTxBuf #2161
Open
liebman
wants to merge
20
commits into
esp-rs:main
Choose a base branch
from
liebman:dma-psram-tx-buf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+511
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liebman
force-pushed
the
dma-psram-tx-buf
branch
from
September 15, 2024 20:19
bfab3ce
to
a6f8bbd
Compare
Lovely, maybe it has something to do with the reduced bandwidth of QSPI vs OSPI? |
bugadani
reviewed
Sep 15, 2024
bugadani
reviewed
Sep 15, 2024
Actually I think it was because one of my modules only has quad psram-2m and I had it configured for opsram-2m example seems to work now |
Dominaezzz
reviewed
Sep 15, 2024
Dominaezzz
reviewed
Sep 15, 2024
Dominaezzz
reviewed
Sep 15, 2024
liebman
force-pushed
the
dma-psram-tx-buf
branch
from
September 16, 2024 17:22
201a9c8
to
62f4d89
Compare
Dominaezzz
reviewed
Sep 16, 2024
6 tasks
Dominaezzz
reviewed
Sep 18, 2024
liebman
force-pushed
the
dma-psram-tx-buf
branch
from
September 18, 2024 22:36
0c8700d
to
e0600ae
Compare
Dominaezzz
reviewed
Sep 18, 2024
liebman
force-pushed
the
dma-psram-tx-buf
branch
2 times, most recently
from
September 19, 2024 19:43
fe8ef3a
to
68f076a
Compare
Dominaezzz
reviewed
Sep 19, 2024
Dominaezzz
reviewed
Sep 19, 2024
liebman
force-pushed
the
dma-psram-tx-buf
branch
from
September 20, 2024 13:26
62381cf
to
0bfddcd
Compare
add `dma_tx_buffer` macro
…ed - its not needed for dram anyway.
liebman
force-pushed
the
dma-psram-tx-buf
branch
from
September 20, 2024 18:31
0bfddcd
to
37f7bff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
This PR adds support for PSRAM in DmaTxBuf allowing DMA transfers out from PSRAM.
Some observations:it seems to only work with octal PSRAMthere seem to be some edge cases wherechanging the CHUNK_SIZE makes it work or failchanging the BUFFER_SIZE makes it work or failTesting