Async-TWAI #1320
Merged
Async-TWAI #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Paul Paterson <ptpaterson@gmail.com>
bjoernQ
changed the title
MabezDev
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
LGTM, thanks for pushing this over the finish line. Could you update #324 once this is merged?
Big thank you to @ptpaterson for the initial implementation, much appreciated! Excited to see this addition in esp-hal :)
8 tasks
|
this is awesome and exactly what we needed, thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
This adds async support for TWAI based on #951
Rebasing wouldn't be very pleasant given 367 PRs got merged in-between so I applied the changes from the original PR here and added the original author as co-author.
It also prepares ESP32 and ESP32-S2. ESP32 (like ESP32-C6) compiles but doesn't work. However, ESP32-S2 works - so I whitelisted the examples for it
Testing
I used two TWAI/CAN transceivers to connect one ESP32-C3 running the blocking twai example and one ESP32-S3 running the async example. Make sure to remove the ".into_open_drain_output()` when using transceivers.