Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time-driver-timg timer1 #1091

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Jan 17, 2024

Fixes #1080

@jessebraham
Copy link
Member

Not sure why, but just noticed your last couple PRs (including this one) seem to have their CHANGELOG.md entries in a previous version. Would you mind fixing these?

Other than that, LGTM.

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good spot, thanks! LGTM!

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Jan 17, 2024

Not sure why, but just noticed your last couple PRs (including this one) seem to have their CHANGELOG.md entries in a previous version. Would you mind fixing these?

Other than that, LGTM.

Ohhhh .... I have no idea - probably forgot to scroll up - seems I was not the only one will fix them all

@jessebraham
Copy link
Member

Must have been a weird rebase or something haha, not sure how/when that happened. Oh well, thanks for fixing it 😁

@jessebraham jessebraham added this pull request to the merge queue Jan 17, 2024
Merged via the queue into esp-rs:main with commit ebe4149 Jan 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESP32/S2/S3: embassy_multiprio.rs example doesn't seem to work as intended when using embassy-time-timg0
3 participants