-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul pt1: Intro, overview and installation #84
Conversation
* Remove the "Resources" and "Glossary" pages * Rewrite most of the introduction chapter * Address review comments
* docs: 📝 Initial rework of installation chapter * docs: 📝 Add build diagram * docs: 📝 Update riscv section * docs: 📝 Update riscv section * docs: 📝 Update Xtensa section * chore: 🔥 Remove build process * style: 🎨 Format troubleshooting chapter * docs: 📝 Update export paths * docs: 📝 Update libtinfo5 error * docs: 📝 Fix typos * fix: 🐛 Fix tests * fix: 🐛 Fix link * fix: 🐛 Fix link * docs: 🐛 Fix note on `no_std` targets * chore: ⚡️ Minor updates to simplify instructions * docs: Fix typo Co-authored-by: Jesse Braham <jessebraham@users.noreply.github.com> * docs: Fix typo Co-authored-by: Jesse Braham <jessebraham@users.noreply.github.com> * docs: Update insallation methods order Co-authored-by: Jesse Braham <jessebraham@users.noreply.github.com> * docs: 📝 Address comments * docs: 📝 Address comments * docs: 📝 Update default no_std riscv target --------- Co-authored-by: Jesse Braham <jessebraham@users.noreply.github.com>
* Update index.md Restructure the chapter Setting Up the Development Environment * Update according to comments from Sergio * Update src/installation/index.md * Update src/installation/index.md * Update src/installation/index.md * Update index.md * Update src/installation/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Apply suggestions from code review Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/installation/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Apply suggestions from code review Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Apply suggestions from code review Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Apply suggestions from code review Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update index.md * Update RISC-V and Xtensa targets section names * Update link variable names * Update src/installation/index.md * Update src/installation/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/installation/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Updates links to alternative espup installation * Update the line on sourcing files on Windows * Remove new line that breaks the note in mdbook * Fix typo * Update src/installation/index.md * Update src/installation/index.md * Update src/installation/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/installation/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/installation/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/installation/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Indent the note under 2. Wndows * Update src/installation/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/installation/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/installation/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Swap Section What espup Installs with Other installation methods * Update src/installation/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Add missing cargo install ldproxy command * Apply suggestions from Dominik Co-authored-by: Dominik Gschwind <dominik.gschwind99@gmail.com> * Update the line about the GCC toolchain * Update src/installation/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Replace Xtensa targets with Espressif targets * Update src/installation/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update the link formatting --------- Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> Co-authored-by: Dominik Gschwind <dominik.gschwind99@gmail.com>
* Update index.md Restructure the chapter Setting Up the Development Environment * Update according to comments from Sergio * Update src/installation/index.md * Update src/installation/index.md * Update src/installation/index.md * Update index.md * Update src/installation/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Apply suggestions from code review Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/installation/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Apply suggestions from code review Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Apply suggestions from code review Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Apply suggestions from code review Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update index.md * Update RISC-V and Xtensa targets section names * Update link variable names * Update index.md * Update comparing-std-and-no_std * Update using-the-standard-library * Update bare-metal * Update table alignment * Update alignment * Restore installation/intex.md to its pre-fork state * Fix title syntax * Update src/overview/bare-metal.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/bare-metal.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/bare-metal.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/bare-metal.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/using-the-standard-library.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/comparing-std-and-no_std.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Implement comments for Sergio * Add a link to ESP8266 HAL * Add the newlib link * Update src/overview/using-the-standard-library.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Add link to esp-idf-release-compatibility table * Add link to esp-idf-release-compatibility table * Update sentence with link to esp-idf compatibility * Delete duplicate link definition * Add intro paragraph to std vs no_std * Remove the intro to esp-idf-svc * Remove Section Software Stacks * Add the table legend * Fix link issue * Update src/overview/comparing-std-and-no_std.md * Move FAQ to Troubleshooting * Add FAQ content * Update table covering no_std crates * Update link to ESP8266 HAL * Update src/overview/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * fix: ⚡️ Update no_std support table * refactor: ♻️ Move comparison to index * fix: 🐛 Fix link * Improve the formatting of a list * Remove the symbol column * feat: 🎨 Update support tables * FIx markdown note formatting issue Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix formatting for a ref to another section Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Add monospace font to terms Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Include section on bare metal from Jurajs blogpost Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Include section on standard library from Jurajs blogpost Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix typos * Update ESP32-H2 curent support --------- Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment that I had missed in previous reviews, but otherwise I think it's good to merge!
> - ESP32 S-Series | ||
> | ||
> The ESP8266 series is outside the scope of this book. Rust support for the | ||
> ESP8266 series is limited and is not being officially supported by Espressif. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The A note in SoCs support and A Note on Device Support blockquotes here seem to be trying to say the same thing, as far as I can tell?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Just fixed it in 02eb301 and added the ESP32 H-Series
since we mention it in other parts of the book
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still don't think we need to mention the H2 at all (as I stated in a previous PR), because we don't support it in either HAL yet, but it's still in here so I won't worry about it too much. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
No description provided.